From: Heinz Mauelshagen <heinzm@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] md: raid10: add prerequisite to run underneath dm-raid
Date: Tue, 3 May 2016 19:58:04 +0200 [thread overview]
Message-ID: <5728E6AC.2070607@redhat.com> (raw)
In-Reply-To: <1462297882.16133.40.camel@HansenPartnership.com>
On 05/03/2016 07:51 PM, James Bottomley wrote:
> On Tue, 2016-05-03 at 19:42 +0200, heinzm@redhat.com wrote:
>> From: Heinz Mauelshagen <heinzm@redhat.com>
>>
>> In case md runs underneath the dm-raid target, the mddev does not
>> have a request queue or gendisk, thus avoid accesses to it.
>>
>> This patch adds two missing conditionals to the raid10 personality.
> -EWRONGLIST. drivers/md is handled by linux-raid@vger.kernel.org
Sorry for the noise...
>
> James
>
>> Signed-of-by: Heinz Mauelshagen <heinzm@redhat.com>
>>
>> ---
>> drivers/md/raid10.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>> index e3fd725..84e24e6 100644
>> --- a/drivers/md/raid10.c
>> +++ b/drivers/md/raid10.c
>> @@ -3782,8 +3782,10 @@ static int raid10_resize(struct mddev *mddev,
>> sector_t sectors)
>> return ret;
>> }
>> md_set_array_sectors(mddev, size);
>> - set_capacity(mddev->gendisk, mddev->array_sectors);
>> - revalidate_disk(mddev->gendisk);
>> + if (mddev->queue) {
>> + set_capacity(mddev->gendisk, mddev->array_sectors);
>> + revalidate_disk(mddev->gendisk);
>> + }
>> if (sectors > mddev->dev_sectors &&
>> mddev->recovery_cp > oldsize) {
>> mddev->recovery_cp = oldsize;
>> @@ -4593,8 +4595,10 @@ static void raid10_finish_reshape(struct mddev
>> *mddev)
>> set_bit(MD_RECOVERY_NEEDED, &mddev
>> ->recovery);
>> }
>> mddev->resync_max_sectors = size;
>> - set_capacity(mddev->gendisk, mddev->array_sectors);
>> - revalidate_disk(mddev->gendisk);
>> + if (mddev->queue) {
>> + set_capacity(mddev->gendisk, mddev
>> ->array_sectors);
>> + revalidate_disk(mddev->gendisk);
>> + }
>> } else {
>> int d;
>> for (d = conf->geo.raid_disks ;
prev parent reply other threads:[~2016-05-03 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 17:42 [PATCH] md: raid10: add prerequisite to run underneath dm-raid heinzm
2016-05-03 17:51 ` James Bottomley
2016-05-03 17:58 ` Heinz Mauelshagen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728E6AC.2070607@redhat.com \
--to=heinzm@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).