Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@stratus.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Fix a bdi reregistration race, v3
Date: Mon, 9 May 2016 09:50:15 -0400	[thread overview]
Message-ID: <57309597.1040903@stratus.com> (raw)
In-Reply-To: <572BAFB0.2020305@stratus.com>

On 05/05/2016 04:40 PM, Joe Lawrence wrote:
> On 05/05/2016 03:58 PM, Bart Van Assche wrote:
>> On 03/28/2016 02:29 PM, Bart Van Assche wrote:
>>> Avoid that the sd driver registers a BDI device with a name that
>>> is still in use. This patch avoids that the following warning gets
>>> triggered:
>>>
>>> [ ... ]
>>
>> (replying to my own e-mail)
>>
>> If anyone could review this patch that would be very welcome.
> 
> Hi Bart,
> 
> I *think* I may be hitting this same problem running some tests here at Stratus
> ... snip...


Hi Bart,

Good news = With your v3 patch, I didn't see the "sysfs: cannot create
duplicate filename '/devices/virtual/bdi/65:0'" warning during my
weekend testing (573 surprise disk HBA removals).

Bad news = I still crashed in add_disk > sysfs_create_link >
sysfs_do_create_link_sd on a NULL target_kobj->sd ... unfortunately I
don't have kdump working, so all I have is a serial console output to
work with for now.

Regards,

-- Joe

  reply	other threads:[~2016-05-09 14:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 21:29 [PATCH] Fix a bdi reregistration race, v3 Bart Van Assche
2016-05-05 19:58 ` Bart Van Assche
2016-05-05 20:40   ` Joe Lawrence
2016-05-09 13:50     ` Joe Lawrence [this message]
2016-06-03 23:25       ` Bart Van Assche
2016-06-15 10:49         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57309597.1040903@stratus.com \
    --to=joe.lawrence@stratus.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox