From: Mike Christie <mchristi@redhat.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
socketpair@gmail.com
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 2/2] target: fix max discard sectors calculation
Date: Mon, 16 May 2016 14:00:56 -0500 [thread overview]
Message-ID: <573A18E8.3040507@redhat.com> (raw)
In-Reply-To: <573A1826.3050007@sandisk.com>
On 05/16/2016 01:57 PM, Bart Van Assche wrote:
> On 05/16/2016 11:46 AM, mchristi@redhat.com wrote:
>> diff --git a/drivers/target/target_core_device.c
>> b/drivers/target/target_core_device.c
>> index a4046ca..3f9f304 100644
>> --- a/drivers/target/target_core_device.c
>> +++ b/drivers/target/target_core_device.c
>> @@ -826,8 +826,8 @@ bool target_configure_unmap_from_queue(struct
>> se_dev_attrib *attrib,
>> - attrib->max_unmap_lba_count = (q->limits.max_discard_sectors << 9) /
>> - block_size;
>> + attrib->max_unmap_lba_count =
>> + ((u64)q->limits.max_discard_sectors << 9) / block_size;
>
> Hello Mike,
>
> That's a good catch. But seeing this patch makes me wonder whether this
> patch introduces a 64-bit division? If so, I'm afraid this patch will
> make 32-bit users unhappy. Have you considered to use do_div() or >>
> (ilog2(block_size) - 9) instead? For the latter alternative no 64-bit
> cast is needed.
>
That is better. Will fix. Thanks.
next prev parent reply other threads:[~2016-05-16 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 18:46 [PATCH 0/2] fix max discard sectors calculation mchristi
2016-05-16 18:46 ` [PATCH 1/2] scsi: " mchristi
2016-05-16 22:44 ` Bart Van Assche
2016-05-17 3:46 ` Mike Christie
2016-05-16 18:46 ` [PATCH 2/2] target: " mchristi
2016-05-16 18:57 ` Bart Van Assche
2016-05-16 19:00 ` Mike Christie [this message]
2016-05-16 19:02 ` Martin K. Petersen
2016-05-17 18:16 ` Bart Van Assche
2016-05-17 21:49 ` Mike Christie
2016-05-18 16:56 ` Bart Van Assche
2016-05-18 17:17 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573A18E8.3040507@redhat.com \
--to=mchristi@redhat.com \
--cc=bart.vanassche@sandisk.com \
--cc=linux-scsi@vger.kernel.org \
--cc=socketpair@gmail.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).