From: James Bottomley <jejb@linux.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Wenchao Hao <haowenchao@huawei.com>,
syzkaller-bugs@googlegroups.com
Cc: fmdefrancesco@gmail.com, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com,
linfeilong@huawei.com
Subject: Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails
Date: Thu, 31 Mar 2022 10:19:57 -0400 [thread overview]
Message-ID: <574d33978be5eb4732cd3bf61727e6b509a7e484.camel@linux.ibm.com> (raw)
In-Reply-To: <20220331134210.GF12805@kadam>
On Thu, 2022-03-31 at 16:42 +0300, Dan Carpenter wrote:
[...]
> Also, I don't really understand why we don't have to call
> put_device(&sdkp->disk_dev) at the end of sd_remove().
That's because the final put is done by the gendisk ->free_disk()
function which is scsi_disk_free_disk(). Most of the gendisk functions
we provide convert a gendisk to a scsi_disk (via the gendisk
private_data), so the sdkp has to live as long as the gendisk.
James
next prev parent reply other threads:[~2022-03-31 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:49 [PATCH] scsi: sd: call device_del() if device_add_disk() fails Fabio M. De Francesco
2022-03-30 4:30 ` Dan Carpenter
2022-03-31 15:26 ` Wenchao Hao
2022-03-31 5:41 ` Dan Carpenter
2022-03-31 5:45 ` Christoph Hellwig
2022-03-31 9:07 ` Fabio M. De Francesco
2022-03-31 9:13 ` Christoph Hellwig
2022-03-31 10:13 ` Fabio M. De Francesco
2022-03-31 12:14 ` Wenchao Hao
2022-03-31 13:42 ` Dan Carpenter
2022-03-31 14:19 ` James Bottomley [this message]
2022-03-31 15:11 ` Dan Carpenter
2022-03-31 16:14 ` Fabio M. De Francesco
2022-03-31 16:24 ` Dan Carpenter
2022-03-31 17:21 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574d33978be5eb4732cd3bf61727e6b509a7e484.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=haowenchao@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox