linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ipr: Fix error return code in ipr_probe_ioa()
@ 2016-07-29 16:00 Wei Yongjun
  2016-07-29 19:53 ` Brian King
  2016-08-02  5:19 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-07-29 16:00 UTC (permalink / raw)
  To: Brian King, James E.J. Bottomley, Martin K. Petersen
  Cc: Wei Yongjun, linux-scsi

Fix to return error code -ENOMEM from the workqueue alloc error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/scsi/ipr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 95e4834..bf85974 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -10219,6 +10219,7 @@ static int ipr_probe_ioa(struct pci_dev *pdev,
 
 		if (!ioa_cfg->reset_work_q) {
 			dev_err(&pdev->dev, "Couldn't register reset workqueue\n");
+			rc = -ENOMEM;
 			goto out_free_irq;
 		}
 	} else


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ipr: Fix error return code in ipr_probe_ioa()
  2016-07-29 16:00 [PATCH -next] ipr: Fix error return code in ipr_probe_ioa() Wei Yongjun
@ 2016-07-29 19:53 ` Brian King
  2016-08-02  5:19 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Brian King @ 2016-07-29 19:53 UTC (permalink / raw)
  To: Wei Yongjun, Brian King, James E.J. Bottomley, Martin K. Petersen
  Cc: linux-scsi

Acked-by: Brian King <brking@linux.vnet.ibm.com>

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ipr: Fix error return code in ipr_probe_ioa()
  2016-07-29 16:00 [PATCH -next] ipr: Fix error return code in ipr_probe_ioa() Wei Yongjun
  2016-07-29 19:53 ` Brian King
@ 2016-08-02  5:19 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-08-02  5:19 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Brian King, James E.J. Bottomley, Martin K. Petersen, linux-scsi

>>>>> "Wei" == Wei Yongjun <weiyj.lk@gmail.com> writes:

Wei> Fix to return error code -ENOMEM from the workqueue alloc error
Wei> handling case instead of 0, as done elsewhere in this function.

Applied to 4.8/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-02  5:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-29 16:00 [PATCH -next] ipr: Fix error return code in ipr_probe_ioa() Wei Yongjun
2016-07-29 19:53 ` Brian King
2016-08-02  5:19 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).