public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-scsi@vger.kernel.org, John Garry <john.garry@huawei.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH 1/2] scsi: core: Add support for reserved tags
Date: Wed, 10 Nov 2021 11:19:06 -0800	[thread overview]
Message-ID: <57aa04ba-edd5-93b9-4e0d-2fda4ccbe975@acm.org> (raw)
In-Reply-To: <139e5cb6-c91e-fa64-f261-6359b6abe376@suse.de>

On 11/9/21 10:59 PM, Hannes Reinecke wrote:
> This is essentially the same patch as I posted a while ago (cf 
> https://lore.kernel.org/linux-scsi/20210222132405.91369-1- hare@suse.de/).
> 
> But there had been push-back on that series as it would also try to use 
> a scsi host device for driver-internal commands.
> 
> Maybe we should combine our efforts; patch 2 is equivalent to your 
> patch, and 3-5 are a conversion of the fnic driver to use those 
> commands. So we should merge our efforts to get this thing off the ground.
> 
> For the remainder of the patchset I'm currently working on a solution to 
> address the upstream concerns.

Hi Hannes,

In the UFS driver we are using a request queue that is not associated 
with any SCSI device for allocating driver-internal tags from the same 
tags space as SCSI commands. Is this a solution that is generic enough 
to be re-used by other SCSI drivers? See also the output of git grep -nH 
'hba->cmd_queue'.

Thanks,

Bart.

  reply	other threads:[~2021-11-10 19:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03  0:05 [PATCH 0/2] Fix a deadlock in the UFS error handler Bart Van Assche
2021-11-03  0:05 ` [PATCH 1/2] scsi: core: Add support for reserved tags Bart Van Assche
2021-11-09 21:09   ` Bart Van Assche
2021-11-10  6:59   ` Hannes Reinecke
2021-11-10 19:19     ` Bart Van Assche [this message]
2021-11-11  6:54       ` Hannes Reinecke
2021-11-15 18:46         ` Bart Van Assche
2021-11-17  0:46         ` Bart Van Assche
2021-11-03  0:05 ` [PATCH 2/2] scsi: ufs: Fix a deadlock in the error handler Bart Van Assche
2021-11-03  6:56   ` Adrian Hunter
2021-11-03 13:40     ` Bart Van Assche
2021-11-03 14:03       ` Adrian Hunter
2021-11-07 11:07     ` Avri Altman
2021-11-08 18:26       ` Bart Van Assche
2021-11-03  7:40   ` Christoph Hellwig
2021-11-03  8:37     ` Adrian Hunter
2021-11-03 16:33       ` Christoph Hellwig
2021-11-03 16:48         ` Bart Van Assche
2021-11-03 13:45     ` Bart Van Assche
2021-11-03 16:27       ` Christoph Hellwig
2021-11-03 16:39         ` Bart Van Assche
2021-11-03 16:41           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57aa04ba-edd5-93b9-4e0d-2fda4ccbe975@acm.org \
    --to=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=jaegeuk@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox