From: Bart Van Assche <bvanassche@acm.org>
To: James Smart <jsmart2021@gmail.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 2/3] scsi: add shost helper to set max queue depth on all of its devices
Date: Thu, 23 Jan 2020 18:52:28 -0800 [thread overview]
Message-ID: <57c43701-b9d1-6f4c-677e-16ac1cd43f43@acm.org> (raw)
In-Reply-To: <20200123222102.23383-3-jsmart2021@gmail.com>
On 2020-01-23 14:21, James Smart wrote:
> /**
> + * shost_change_max_queue_depths - helper to walk all devices on a
^^
a single space here is probably sufficient?
> + if (!shost->hostt->change_queue_depth)
> + return -ENOTSUPP;
ENOTSUPP is defined in include/linux/errno.h so that's a kernel-internal
error code. I think only error codes from
include/uapi/asm-generic/errno*.h should be returned to user space.
> + if (depth < 1 || depth > shost->can_queue)
> + return -EINVAL;
Thanks,
Bart.
next prev parent reply other threads:[~2020-01-24 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 22:20 [PATCH v2 0/3] scsi: add attribute to set lun queue depth on all luns on shost James Smart
2020-01-23 22:21 ` [PATCH v2 1/3] scsi: refactor sdev lun queue depth setting via sysfs James Smart
2020-01-24 2:48 ` Bart Van Assche
2020-01-23 22:21 ` [PATCH v2 2/3] scsi: add shost helper to set max queue depth on all of its devices James Smart
2020-01-24 2:52 ` Bart Van Assche [this message]
2020-01-23 22:21 ` [PATCH v2 3/3] scsi: add shost attribute to set max queue depth on all devices on the shost James Smart
2020-01-24 2:55 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c43701-b9d1-6f4c-677e-16ac1cd43f43@acm.org \
--to=bvanassche@acm.org \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox