Re: [PATCH v2 3/9] ufs: core: Introduce ufshcd_post_device_init()

Bart Van Assche
2024-08-28T17:05:51Z

On 8/25/24 1:16 AM, Manivannan Sadhasivam wrote:
> On Thu, Aug 22, 2024 at 02:36:04PM -0700, Bart Van Assche wrote:
>> +static int ufshcd_post_device_init(struct ufs_hba *hba)
>> +{
>> + int ret;
>> +
>> + ufshcd_tune_unipro_params(hba);
>> +
>> + /* UFS device is also active now */
>> + ufshcd_set_ufs_dev_active(hba);
>> + ufshcd_force_reset_auto_bkops(hba);
>> +
>> + ufshcd_set_timestamp_attr(hba);
>> + schedule_delayed_work(&hba->ufs_rtc_update_work,
>> + msecs_to_jiffies(UFS_RTC_UPDATE_INTERVAL_MS));
>> +
>> + if (!hba->max_pwr_info.is_valid)
>> + return 0;
>> +
>> + /* Gear up to HS gear. */
>
> Maybe this comment now belongs above ufshcd_config_pwr_mode()?

Hi Manivannan,

Thanks for the feedback. I will move that comment.

Bart.