From: Bart Van Assche <bvanassche@acm.org>
To: Wenchao Hao <haowenchao2@huawei.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
louhongxiang@huawei.com
Subject: Re: [PATCH v3 2/2] scsi: Add comment of target_destroy in scsi_host_template
Date: Wed, 18 Oct 2023 11:03:57 -0700 [thread overview]
Message-ID: <58513668-33ae-4375-92cd-96a4d9a4a67f@acm.org> (raw)
In-Reply-To: <20231018113746.1940197-3-haowenchao2@huawei.com>
On 10/18/23 04:37, Wenchao Hao wrote:
> Add comment to tell callback function target_destroy of
> scsi_host_template must not sleep.
>
> Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
> ---
> include/scsi/scsi_host.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index 49f768d0ff37..2c61dd30d766 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -245,6 +245,9 @@ struct scsi_host_template {
> * midlayer calls this point so that the driver may deallocate
> * and terminate any references to the target.
> *
> + * Note: This callback is called with the host lock held and hence
> + * must not sleep.
> + *
> * Status: OPTIONAL
> */
> void (* target_destroy)(struct scsi_target *);
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2023-10-18 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 11:37 [PATCH v3 0/2] cleanup patch Wenchao Hao
2023-10-18 11:37 ` [PATCH v3 1/2] scsi: core: cleanup scsi_dev_queue_ready() Wenchao Hao
2023-10-18 18:07 ` Bart Van Assche
2023-10-18 11:37 ` [PATCH v3 2/2] scsi: Add comment of target_destroy in scsi_host_template Wenchao Hao
2023-10-18 18:03 ` Bart Van Assche [this message]
2023-10-25 2:31 ` [PATCH v3 0/2] cleanup patch Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58513668-33ae-4375-92cd-96a4d9a4a67f@acm.org \
--to=bvanassche@acm.org \
--cc=haowenchao2@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox