From: Luben Tuikov <ltuikov@yahoo.com>
To: linux-scsi <linux-scsi@vger.kernel.org>
Cc: Kai Makisara <kai.makisara@kolumbus.fi>
Subject: [PATCH] [SCSI] st.c: Improve sense output
Date: Sat, 4 Nov 2006 12:02:57 -0800 (PST) [thread overview]
Message-ID: <587723.63610.qm@web31807.mail.mud.yahoo.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
>From this:
st0: Error with sense data: <6>st: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb
To this:
st0: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
drivers/scsi/st.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
March 24, 2006!
Luben
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 2928128166-st.txt --]
[-- Type: text/inline; name="st.txt", Size: 982 bytes --]
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 29d7319..2a59635 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -368,7 +368,7 @@ static int st_chk_result(struct scsi_tap
SRpnt->cmd[0], SRpnt->cmd[1], SRpnt->cmd[2],
SRpnt->cmd[3], SRpnt->cmd[4], SRpnt->cmd[5]);
if (cmdstatp->have_sense)
- __scsi_print_sense("st", SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
+ __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
} ) /* end DEB */
if (!debugging) { /* Abnormal conditions for tape */
if (!cmdstatp->have_sense)
@@ -384,9 +384,8 @@ static int st_chk_result(struct scsi_tap
scode != VOLUME_OVERFLOW &&
SRpnt->cmd[0] != MODE_SENSE &&
SRpnt->cmd[0] != TEST_UNIT_READY) {
- printk(KERN_WARNING "%s: Error with sense data: ", name);
- __scsi_print_sense("st", SRpnt->sense,
- SCSI_SENSE_BUFFERSIZE);
+
+ __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
}
}
--
1.4.3.3.g8478
next reply other threads:[~2006-11-04 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 20:02 Luben Tuikov [this message]
2006-11-07 19:42 ` [PATCH] [SCSI] st.c: Improve sense output Kai Makisara
-- strict thread matches above, loose matches on Subject: below --
2006-07-01 1:07 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587723.63610.qm@web31807.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=kai.makisara@kolumbus.fi \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox