* [PATCH] [SCSI] st.c: Improve sense output
@ 2006-07-01 1:07 Luben Tuikov
0 siblings, 0 replies; 3+ messages in thread
From: Luben Tuikov @ 2006-07-01 1:07 UTC (permalink / raw)
To: linux-scsi; +Cc: Andrew Morton
>From this:
st0: Error with sense data: <6>st: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb
To this:
st0: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
drivers/scsi/st.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 29d7319..2a59635 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -368,7 +368,7 @@ static int st_chk_result(struct scsi_tap
SRpnt->cmd[0], SRpnt->cmd[1], SRpnt->cmd[2],
SRpnt->cmd[3], SRpnt->cmd[4], SRpnt->cmd[5]);
if (cmdstatp->have_sense)
- __scsi_print_sense("st", SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
+ __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
} ) /* end DEB */
if (!debugging) { /* Abnormal conditions for tape */
if (!cmdstatp->have_sense)
@@ -384,9 +384,8 @@ static int st_chk_result(struct scsi_tap
scode != VOLUME_OVERFLOW &&
SRpnt->cmd[0] != MODE_SENSE &&
SRpnt->cmd[0] != TEST_UNIT_READY) {
- printk(KERN_WARNING "%s: Error with sense data: ", name);
- __scsi_print_sense("st", SRpnt->sense,
- SCSI_SENSE_BUFFERSIZE);
+
+ __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
}
}
--
1.4.1.rc2.g4ce4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] [SCSI] st.c: Improve sense output
@ 2006-11-04 20:02 Luben Tuikov
2006-11-07 19:42 ` Kai Makisara
0 siblings, 1 reply; 3+ messages in thread
From: Luben Tuikov @ 2006-11-04 20:02 UTC (permalink / raw)
To: linux-scsi; +Cc: Kai Makisara
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
>From this:
st0: Error with sense data: <6>st: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb
To this:
st0: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
drivers/scsi/st.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
March 24, 2006!
Luben
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 2928128166-st.txt --]
[-- Type: text/inline; name="st.txt", Size: 982 bytes --]
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 29d7319..2a59635 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -368,7 +368,7 @@ static int st_chk_result(struct scsi_tap
SRpnt->cmd[0], SRpnt->cmd[1], SRpnt->cmd[2],
SRpnt->cmd[3], SRpnt->cmd[4], SRpnt->cmd[5]);
if (cmdstatp->have_sense)
- __scsi_print_sense("st", SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
+ __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
} ) /* end DEB */
if (!debugging) { /* Abnormal conditions for tape */
if (!cmdstatp->have_sense)
@@ -384,9 +384,8 @@ static int st_chk_result(struct scsi_tap
scode != VOLUME_OVERFLOW &&
SRpnt->cmd[0] != MODE_SENSE &&
SRpnt->cmd[0] != TEST_UNIT_READY) {
- printk(KERN_WARNING "%s: Error with sense data: ", name);
- __scsi_print_sense("st", SRpnt->sense,
- SCSI_SENSE_BUFFERSIZE);
+
+ __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
}
}
--
1.4.3.3.g8478
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [SCSI] st.c: Improve sense output
2006-11-04 20:02 [PATCH] [SCSI] st.c: Improve sense output Luben Tuikov
@ 2006-11-07 19:42 ` Kai Makisara
0 siblings, 0 replies; 3+ messages in thread
From: Kai Makisara @ 2006-11-07 19:42 UTC (permalink / raw)
To: Luben Tuikov; +Cc: linux-scsi
On Sat, 4 Nov 2006, Luben Tuikov wrote:
> >From this:
> st0: Error with sense data: <6>st: Current: sense key: Illegal Request
> Additional sense: Invalid field in cdb
>
> To this:
> st0: Current: sense key: Illegal Request
> Additional sense: Invalid field in cdb
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
> drivers/scsi/st.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> March 24, 2006!
>
This is already in the official kernel.
--
Kai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-07 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-04 20:02 [PATCH] [SCSI] st.c: Improve sense output Luben Tuikov
2006-11-07 19:42 ` Kai Makisara
-- strict thread matches above, loose matches on Subject: below --
2006-07-01 1:07 Luben Tuikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox