From: Bean Huo <huobean@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Avri Altman <Avri.Altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Can Guo <cang@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Stanley Chu <stanley.chu@mediatek.com>
Subject: Re: [PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and_restore()
Date: Tue, 02 Mar 2021 14:04:38 +0100 [thread overview]
Message-ID: <58e8dcea7f3567001c807ca9399f191a4bcaea40.camel@gmail.com> (raw)
In-Reply-To: <5fe97f16-406c-c279-b108-d27bb2769ed6@intel.com>
On Tue, 2021-03-02 at 10:14 +0200, Adrian Hunter wrote:
> > > That can result in the state being UFSHCD_STATE_ERROR even though
> > > ufshcd_reset_and_restore() is successful and returns zero.
> > >
> > > Fix by initializing the state to UFSHCD_STATE_RESET in the start
> > > of each
> > > loop in ufshcd_reset_and_restore(). If there is an error,
> > > ufshcd_reset_and_restore() will change the state to
> > > UFSHCD_STATE_ERROR,
> > > otherwise ufshcd_probe_hba() will have set the state
> > > appropriately.
> > >
> > > Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler
> > > and other
> > > error recovery paths")
> > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> >
> > I think that CanG recent series addressed that issue as well, can
> > you take a look?
> >
https://lore.kernel.org/lkml/1614145010-36079-2-git-send-email-cang@codeaurora.org/
>
> Yes, there it is mixed in with other changes. However it is probably
> better
> as a separate patch. Can Guo, what do you think?
we can firstly take this fixup patch.
next prev parent reply other threads:[~2021-03-02 19:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 19:19 [PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and_restore() Adrian Hunter
2021-03-01 20:46 ` Bean Huo
2021-03-01 23:54 ` Asutosh Das
2021-03-02 7:01 ` Avri Altman
2021-03-02 8:14 ` Adrian Hunter
2021-03-02 13:04 ` Bean Huo [this message]
2021-03-03 10:19 ` Can Guo
2021-03-03 10:05 ` Can Guo
2021-03-04 4:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58e8dcea7f3567001c807ca9399f191a4bcaea40.camel@gmail.com \
--to=huobean@gmail.com \
--cc=Avri.Altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox