linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <mchristi@redhat.com>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>, nab@linux-iscsi.org
Cc: seroyer@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] tcmu: Add Type of reconfig into netlink
Date: Mon, 5 Jun 2017 21:10:33 -0500	[thread overview]
Message-ID: <59360F19.2010806@redhat.com> (raw)
In-Reply-To: <1496169080-58746-6-git-send-email-bryantly@linux.vnet.ibm.com>

On 05/30/2017 01:31 PM, Bryant G. Ly wrote:
> This patch adds more info about the attribute being changed,
> so that usersapce can easily figure out what is happening.
> 
> Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> ---
>  drivers/target/target_core_user.c     | 27 +++++++++++++++++++++------
>  include/uapi/linux/target_core_user.h |  1 +
>  2 files changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 7575bc9..2d461c4 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -190,6 +190,13 @@ static struct genl_family tcmu_genl_family __ro_after_init = {
>  	.netnsok = true,
>  };
>  
> +enum tcmu_reconfig_types {
> +	No_reconfig,
> +	Config_path,
> +	Config_size,
> +	Config_writecache

This this goes in target_core_user.h.

Let's just do all caps for the names to make the style in there.

  reply	other threads:[~2017-06-06  2:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 18:31 [PATCH v2 0/5] TCMU Enable Reconfiguration Patches Bryant G. Ly
2017-05-30 18:31 ` [PATCH v2 1/5] tcmu: Support emulate_write_cache Bryant G. Ly
2017-05-30 18:31 ` [PATCH v2 2/5] tcmu: Add netlink for device reconfiguration Bryant G. Ly
2017-05-30 18:31 ` [PATCH v2 3/5] tcmu: Make dev_size configurable via userspace Bryant G. Ly
2017-05-30 18:31 ` [PATCH v2 4/5] tcmu: Make dev_config configurable Bryant G. Ly
2017-05-30 23:21   ` kbuild test robot
2017-06-06  2:02   ` Mike Christie
2017-05-30 18:31 ` [PATCH v2 5/5] tcmu: Add Type of reconfig into netlink Bryant G. Ly
2017-06-06  2:10   ` Mike Christie [this message]
2017-06-03  6:58 ` [PATCH v2 0/5] TCMU Enable Reconfiguration Patches Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59360F19.2010806@redhat.com \
    --to=mchristi@redhat.com \
    --cc=bryantly@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=seroyer@linux.vnet.ibm.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).