From: walter harms <wharms@bfs.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: QLogic-Storage-Upstream@cavium.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] scsi: qedf: Fix a return value in case of error in 'qedf_alloc_global_queues'
Date: Sun, 11 Jun 2017 10:33:11 +0200 [thread overview]
Message-ID: <593D0047.1040306@bfs.de> (raw)
In-Reply-To: <7674c3a305022d1e30b7e7b744b673713fd50117.1497160148.git.christophe.jaillet@wanadoo.fr>
Am 11.06.2017 08:16, schrieb Christophe JAILLET:
> We should return -ENOMEM in case of memory allocation error, as done
> elsewhere in this function.
>
> Fixes: 61d8658b4a435 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/scsi/qedf/qedf_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index aab3e2bd26a0..52a27100ca6d 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2673,6 +2673,7 @@ static int qedf_alloc_global_queues(struct qedf_ctx *qedf)
> if (!qedf->global_queues[i]) {
> QEDF_WARN(&(qedf->dbg_ctx), "Unable to allocation "
> "global queue %d.\n", i);
> + status = -ENOMEM;
> goto mem_alloc_failure;
> }
>
I am not native english but the error msg sounds strange ...
re,
wh
next prev parent reply other threads:[~2017-06-11 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 6:16 [PATCH 0/3] scsi: qedf: Fix a return value + some cleanups Christophe JAILLET
2017-06-11 6:16 ` [PATCH 1/3] scsi: qedf: Fix a return value in case of error in 'qedf_alloc_global_queues' Christophe JAILLET
2017-06-11 8:33 ` walter harms [this message]
2017-06-11 6:16 ` [PATCH 2/3] scsi: qedf: Use 'dma_zalloc_coherent' to reduce code verbosity Christophe JAILLET
2017-06-11 6:16 ` [PATCH 3/3] scsi: qedf: Merge a few quoted strings split across lines Christophe JAILLET
2017-06-12 14:03 ` [PATCH 0/3] scsi: qedf: Fix a return value + some cleanups Chad Dupuis
2017-06-13 1:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593D0047.1040306@bfs.de \
--to=wharms@bfs.de \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).