From: Mike Christie <mchristi@redhat.com>
To: Matthew Wilcox <willy@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Hannes Reinecke <hare@suse.com>,
Kees Cook <keescook@chromium.org>,
Varun Prakash <varun@chelsio.com>,
Sagi Grimberg <sagi@grimberg.me>,
Philippe Ombredanne <pombredanne@nexb.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 18/26] target/iscsi: Allocate session IDs from an IDA
Date: Tue, 31 Jul 2018 13:55:26 -0500 [thread overview]
Message-ID: <5B60B09E.3040402@redhat.com> (raw)
In-Reply-To: <20180731181510.GA16794@bombadil.infradead.org>
On 07/31/2018 01:15 PM, Matthew Wilcox wrote:
> On Mon, Jul 30, 2018 at 10:03:21PM -0400, Martin K. Petersen wrote:
>>
>> Mike,
>>
>>>> How about I take it through my tree to minimise the amount of rebasing
>>>> I'll need to do? I'm already dependent on the nvdimm tree and I'd rather
>>>> not depend on the scsi tree as well. I'll queue it up in front of my
>>>> IDA change to maximise its backportability.
>>>
>>> Ccing Martin, because he has been handling target patches.
>>
>> That's fine with me.
>>
>> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> Thanks, Martin. Mike, can I have your Signed-off-by: on the original patch?
Yes,
Signed-off-by: Mike Christie <mchristi@redhat.com>
> What Fixes: line should this have? As far as I can tell, the bug is present
> all the way back to its introduction, so:
>
> Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
>
> yes?
The session_index bug was in that patch, but I think it correctly kfreed
the session in __iscsi_target_login_thread.
I think it was this one that added the early kfree bug:
commit 0957627a99604f379d35831897a2aa15272528fc
Author: Nicholas Bellinger <nab@linux-iscsi.org>
Date: Fri Nov 4 11:36:38 2011 -0700
iscsi-target: Fix sess allocation leak in iscsi_login_zero_tsih_s1
Dan's tools probably just did not catch the iscsi_login_zero_tsih_s1 ->
iscsi_login_set_conn_values call that sets conn->sess then later
kfree(conn->sess) call in the error handling in __iscsi_target_login_thread.
prev parent reply other threads:[~2018-07-31 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180621212835.5636-1-willy@infradead.org>
2018-06-21 21:28 ` [PATCH 08/26] sd: Convert to new IDA interface Matthew Wilcox
2018-06-21 21:28 ` [PATCH 09/26] osd: Convert to new IDA API Matthew Wilcox
2018-06-21 21:28 ` [PATCH 18/26] target/iscsi: Allocate session IDs from an IDA Matthew Wilcox
2018-07-26 16:48 ` Mike Christie
2018-07-26 16:50 ` Mike Christie
2018-07-26 17:13 ` Mike Christie
2018-07-27 19:38 ` Matthew Wilcox
2018-07-27 21:05 ` Mike Christie
2018-07-31 2:03 ` Martin K. Petersen
2018-07-31 18:15 ` Matthew Wilcox
2018-07-31 18:55 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B60B09E.3040402@redhat.com \
--to=mchristi@redhat.com \
--cc=bart.vanassche@wdc.com \
--cc=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=pombredanne@nexb.com \
--cc=sagi@grimberg.me \
--cc=target-devel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=varun@chelsio.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox