Re: [PATCH] scsi: fcoe: add missed kfree() in an error path

Markus Elfring
2020-07-07T11:38:56Z

> fcoe_fdmi_info() misses to call kfree() in an error path.
> Add the missed function call to fix it.

I suggest to use an additional jump target for the completion
of the desired exception handling.

…
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -830,6 +830,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev)
> if (rc) {
> printk(KERN_INFO "fcoe: Failed to retrieve FDMI "
> "information from netdev.\n");
> + kfree(fdmi);
> return;
> }

- return;
+ goto free_fdmi;

How do you think about to apply any further coding style adjustments?

Regards,
Markus