From: Bart Van Assche <bvanassche@acm.org>
To: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"ahalaney@redhat.com" <ahalaney@redhat.com>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"beanhuo@micron.com" <beanhuo@micron.com>
Subject: Re: [PATCH v3 3/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze
Date: Thu, 12 Sep 2024 14:19:50 -0700 [thread overview]
Message-ID: <5bc3f6e9-5ed2-47ff-a442-4495fc8ae8b4@acm.org> (raw)
In-Reply-To: <d9827ee4adf5049ba27e857de0815b0006044147.camel@mediatek.com>
On 9/12/24 6:27 AM, Peter Wang (王信友) wrote:
> On Wed, 2024-09-11 at 17:30 -0700, Bart Van Assche wrote:
>> @@ -5462,10 +5462,13 @@ static irqreturn_t
>> ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status)
>>
>> spin_lock(hba->host->host_lock);
>> cmd = hba->active_uic_cmd;
>> + if (!cmd)
>> + goto unlock;
>> +
>
> Could add a warning line in this case?
> WARN_ON(!cmd);
> I'm worried that if this situation occurs, we won't have
> enough information to debug.
I will do that.
Thanks,
Bart.
next prev parent reply other threads:[~2024-09-12 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 0:30 [PATCH v3 0/4] Clean up the UFS driver UIC code Bart Van Assche
2024-09-12 0:30 ` [PATCH v3 1/4] scsi: ufs: core: Improve the struct ufs_hba documentation Bart Van Assche
2024-09-12 0:30 ` [PATCH v3 2/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to read Bart Van Assche
2024-09-12 0:30 ` [PATCH v3 3/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze Bart Van Assche
2024-09-12 13:27 ` Peter Wang (王信友)
2024-09-12 21:19 ` Bart Van Assche [this message]
2024-09-12 0:30 ` [PATCH v3 4/4] scsi: ufs: core: Always initialize the UIC done completion Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc3f6e9-5ed2-47ff-a442-4495fc8ae8b4@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox