From: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
Subramanian Seetharaman <subbu.seetharaman@broadcom.com>,
Ketan Mukadam <ketan.mukadam@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-scsi@vger.kernel.org
Subject: RE: [PATCH -next] scsi: be2iscsi: Use GFP_ATOMIC under spin lock
Date: Wed, 18 Jan 2017 10:36:25 +0530 [thread overview]
Message-ID: <5d5887c7afd4a02f2af25f293b1d95a8@mail.gmail.com> (raw)
In-Reply-To: <20170112142132.14552-1-weiyj.lk@gmail.com>
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: Thursday, January 12, 2017 7:52 PM
> To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J.
> Bottomley; Martin K. Petersen
> Cc: Wei Yongjun; linux-scsi@vger.kernel.org
> Subject: [PATCH -next] scsi: be2iscsi: Use GFP_ATOMIC under spin lock
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> A spin lock is taken here so we should use GFP_ATOMIC.
>
> Fixes: 987132167f4b ("scsi: be2iscsi: Fix for crash in
beiscsi_eh_device_reset")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/scsi/be2iscsi/be_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c
b/drivers/scsi/be2iscsi/be_main.c
> index 6372613..c9b9daa 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -294,7 +294,7 @@ static int beiscsi_eh_device_reset(struct scsi_cmnd
> *sc)
> beiscsi_conn = conn->dd_data;
> phba = beiscsi_conn->phba;
>
> - inv_tbl = kzalloc(sizeof(*inv_tbl), GFP_KERNEL);
> + inv_tbl = kzalloc(sizeof(*inv_tbl), GFP_ATOMIC);
> if (!inv_tbl) {
> spin_unlock_bh(&session->frwd_lock);
> beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH,
Reviewed-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
next prev parent reply other threads:[~2017-01-18 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 14:21 [PATCH -next] scsi: be2iscsi: Use GFP_ATOMIC under spin lock Wei Yongjun
2017-01-18 5:06 ` Jitendra Bhivare [this message]
2017-01-20 21:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5887c7afd4a02f2af25f293b1d95a8@mail.gmail.com \
--to=jitendra.bhivare@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=ketan.mukadam@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=subbu.seetharaman@broadcom.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).