From: Kashyap Desai <kashyap.desai@broadcom.com>
To: John Garry <john.garry@huawei.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: RE: [PATCH v2 4/4] scsi: set shost as hctx driver_data
Date: Thu, 3 Dec 2020 19:00:59 +0530 [thread overview]
Message-ID: <5d8d57aa81706e44b4e7a25dae606f39@mail.gmail.com> (raw)
In-Reply-To: <3ee6826b-e010-8874-0447-da8e9b1e8971@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
> -----Original Message-----
> From: John Garry [mailto:john.garry@huawei.com]
> Sent: Thursday, December 3, 2020 6:57 PM
> To: Kashyap Desai <kashyap.desai@broadcom.com>; linux-
> scsi@vger.kernel.org; linux-block@vger.kernel.org
> Subject: Re: [PATCH v2 4/4] scsi: set shost as hctx driver_data
>
> On 03/12/2020 03:41, Kashyap Desai wrote:
> > hctx->driver_data is not set for SCSI currently.
> > Separately set hctx->driver_data = shost.
>
> nit: this looks ok to me, but I would have made as an earlier patch so
> that you
> don't add code and then remove it:
I added later - Just in case someone report issue in " scsi_commit_rqs" due
to this patch, we can revert back easily.
I tested scsi_mq_poll but not scsi_commit_rqs part.
Kashyap
>
> > static int scsi_mq_poll(struct blk_mq_hw_ctx *hctx)
> > {
> > - struct request_queue *q = hctx->queue;
> > - struct scsi_device *sdev = q->queuedata;
> > - struct Scsi_Host *shost = sdev->host;
>
> Thanks,
> John
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4169 bytes --]
next prev parent reply other threads:[~2020-12-03 13:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:40 [PATCH v2 0/4] io_uring iopoll in scsi layer Kashyap Desai
2020-12-03 3:40 ` [PATCH v2 1/4] add io_uring with IOPOLL support " Kashyap Desai
2020-12-03 12:51 ` Hannes Reinecke
2020-12-04 8:53 ` John Garry
2020-12-03 3:40 ` [PATCH v2 2/4] megaraid_sas: iouring iopoll support Kashyap Desai
2020-12-03 12:57 ` Hannes Reinecke
2021-02-01 13:55 ` Kashyap Desai
2020-12-03 13:23 ` kernel test robot
2020-12-03 3:40 ` [PATCH v2 3/4] scsi_debug : " Kashyap Desai
2020-12-03 12:58 ` Hannes Reinecke
2020-12-03 19:09 ` Douglas Gilbert
2020-12-03 3:41 ` [PATCH v2 4/4] scsi: set shost as hctx driver_data Kashyap Desai
2020-12-03 13:26 ` John Garry
2020-12-03 13:30 ` Kashyap Desai [this message]
2020-12-04 9:00 ` John Garry
2021-01-11 12:15 ` [PATCH v2 0/4] io_uring iopoll in scsi layer Kashyap Desai
2021-01-13 3:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d8d57aa81706e44b4e7a25dae606f39@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox