Re: [PATCH] scsi: megaraid_sas: fix double kfree

[Guixin Liu <kanie@linux.alibaba.com>]

Hi,

Gentle ping.

在 2022/8/2 15:18, Guixin Liu 写道:
> When alloc log_to_span fail, call kfree(instance->ctrl_context) first,
> then jump to megasas_free_ctrl_mem() in megasas_init_fw(), call
> kfree(instance->ctrl_context) second.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
>   drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 5b5885d..3e9b2b0 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -5311,7 +5311,6 @@ void megasas_fusion_ocr_wq(struct work_struct *work)
>   		if (!fusion->log_to_span) {
>   			dev_err(&instance->pdev->dev, "Failed from %s %d\n",
>   				__func__, __LINE__);
> -			kfree(instance->ctrl_context);
>   			return -ENOMEM;
>   		}
>   	}