From: Bart Van Assche <bvanassche@acm.org>
To: Kiwoong Kim <kwmad.kim@samsung.com>,
linux-scsi@vger.kernel.org, alim.akhtar@samsung.com,
avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, beanhuo@micron.com,
asutoshd@codeaurora.org, cang@codeaurora.org
Subject: Re: [RFC PATCH v1 1/2] ufs: support various values per device
Date: Sat, 20 Jun 2020 09:26:29 -0700 [thread overview]
Message-ID: <5ed422cb-ad63-e085-cfe4-ac7d78b1ac87@acm.org> (raw)
In-Reply-To: <1592638297-36155-2-git-send-email-kwmad.kim@samsung.com>
On 2020-06-20 00:31, Kiwoong Kim wrote:
> #define END_FIX { }
The name of this macro is longer than its value. Additionally, this
macro makes code harder to read instead of easier. Please include a
patch to remove this macro from the UFS driver.
> +#define UFS_DEV_VAL(_vendor, _model, _key, _val) { \
> + .wmanufacturerid = (_vendor),\
> + .model = (_model), \
> + .key = (_key), \
> + .val = (_val), \
> +}
A macro like the above also makes code harder to read instead of easier.
Please remove this macro definition and use the designated
initialization style directly.
Thanks,
Bart.
next prev parent reply other threads:[~2020-06-20 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200620073912epcas2p469d0082af35ff54a8e84793feed2ab6d@epcas2p4.samsung.com>
2020-06-20 7:31 ` [RFC PATCH v1 0/2] support various values per device Kiwoong Kim
2020-06-20 7:31 ` [RFC PATCH v1 1/2] ufs: " Kiwoong Kim
2020-06-20 16:26 ` Bart Van Assche [this message]
2020-06-23 1:50 ` Kiwoong Kim
2020-06-20 7:31 ` [RFC PATCH v1 2/2] ufs: change the way to complete fDeviceInit Kiwoong Kim
2020-06-20 16:27 ` Bart Van Assche
2020-06-23 1:51 ` Kiwoong Kim
2020-06-21 8:22 ` [RFC PATCH v1 0/2] support various values per device Avri Altman
2020-06-23 2:14 ` Kiwoong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ed422cb-ad63-e085-cfe4-ac7d78b1ac87@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox