Re: [PATCH V3 6.19/scsi-queue] scsi: target: core: Add emulation for REPORT_IDENTIFYING_INFORMATION

[John Garry <john.g.garry@oracle.com>]

On 01/12/2025 11:07, Gulam Mohamed wrote:
> Add the emulation for REPORT_IDENTIFYING_INFORMATION command using the
> configfs file pd_text_id_info in target core module. The configfs file is
> created in /sys/kernel/config/target/core/<backend type>/
> <backing_store_name>/wwn/. The user can set the peripheral device text
> identification string to the file pd_text_id_info. An emulation function
> "spc_emulate_report_id_info()" is defined in target_core_spc.c which
> returns the device text id whenever the user requests the same.
> 
> The details of the REPORT_IDENTIFYING_INFORMATION command is mentioned
> in the section 6.32 of spc4r37 specification document of SCSI Primary
> Commands.
> 
> Signed-off-by: Gulam Mohamed <gulam.mohamed@oracle.com>

thanks for doing an update

Reviewed-by: John Garry <john.g.garry@oracle.com>

BTW, if you do the changes according to the recommendation and those 
changes are straightforward, then you should add the RB tag granted.