From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4417ECAAD8 for ; Fri, 16 Sep 2022 13:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbiIPNEV (ORCPT ); Fri, 16 Sep 2022 09:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231280AbiIPNET (ORCPT ); Fri, 16 Sep 2022 09:04:19 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E14EA61E3 for ; Fri, 16 Sep 2022 06:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1663333458; x=1694869458; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8uoHHIwUQKrb8pYzmvUVItwQhl40ALZcPv5oX6VejrQ=; b=KbYQY20M8i2TM66tl9QDzKjR9o9NvVeUvVP6oKE3mqdvIUVGogmUUu2R qLd0xUGvEtMVrFB2CnNK0sSgnyFezMzQg5sBmtWa4BVFg6fvvQZcddUb3 czyqLI5k8yJyyEqzPyIGqXqIHGtfxScRJn6YP+KwvczMDX8wsh3+ZXJGX vzsEo0lICkgw5xAON8o8rKeJojDVUoqP+SCPeva59nfraDrCZ47nDnPDU caPtJE+7xoaGWdzbrMKtsDcX9NKoIaDXjwOX9gjyTMt+vfcoPsDVZd+IT VNOkryE6Hvq3nbbrPLcoCotsafW2SBc+BB4Ewh2uI+YvRbKfkNvShLiAP g==; X-IronPort-AV: E=Sophos;i="5.93,320,1654531200"; d="scan'208";a="209926696" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 16 Sep 2022 21:04:17 +0800 IronPort-SDR: jKS4BEizIypqevCDl98gOKfKqiPeNFBsg4rYNXFJ+ECCBrjXvmUH4qTPUfiUFFcWteyPXZJBQg mhyKiXbXgdImOOVAyxDSXTZh4Kryu/H1FouWQZLaZKjPbWtdlJNqNOH76dljd1Fh9Ty7w8qX11 wPo3cJeLznRCap4wZzuE79HDPKsr99Bz6iuv9lCT7PsPDcgDu4RSZ3a6hHq/2NPQCjUINWSzcJ /bXswRmihBrlMHnuu5r0hijRi952OfpgyMv+necN6oRfWVczQP7q30YgQcRa2853Aibje1o4kC vL8PJERI3QYat51ckCh3esIr Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 05:24:27 -0700 IronPort-SDR: +xs6eJsW/RlICMr6x0zimrwwxX49iYRjGPlOLw+Wy8sy5+mswGHZ4Aynrw0mn1k5pM2c6yzTaO VB9dL8JdmGDhXlLJYRKeo9hf0qfb7qI5sANxuDP1T79qzxHp14GjXduJKg77TBYI4jp8ETMErB p2r7Zj6XYr9cCAKoqM7Gm8zYoEDfChlgp8fWIXuLIQz3vnkK1P+W4uqOKtv/vPOjPd5xYNkwls PzpgAAyc1jKM6cWEpwHQNNM4/c+QUuBUOkzCI2JqhXJQmLzcyI4tBA5ytUENp9wdz8q3jc2dyo gDM= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2022 06:04:17 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MTZ5r72n2z1RvTp for ; Fri, 16 Sep 2022 06:04:16 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1663333455; x=1665925456; bh=8uoHHIwUQKrb8pYzmvUVItwQhl40ALZcPv5 oX6VejrQ=; b=Y8n3lsQKL5bwusuNFjuUth5bkW53PB4sxCQFuKNreEWyevp+dQJ dCkaw6ik5iITJJHBd8g3R1hXmxlq81HZbQHrNBPIhjCYIM/3S+x4DxSl8SumRx3V 1wudEbA1VW8+2eR34IUUsP/w4TNDmDeNtRVgH68eOM+GjBNqxvDCY14idKMjFGjg 5n+pQ7bA2mBiJV/60EL8xCo7s/kmMFNRd7QLD2ZVWqvFtwR1a1f4QGzxAHebgzsw sHS5FcrCY4bm4VBBWQJLjo4LAu4wGzVMZxgqzG4lIa2i9HJ1NzzUU5gqDZebLRJo hhd0JS++NMB44JMzdKCclJT5N4tWVzKw0SQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gAVvFFp1jPiU for ; Fri, 16 Sep 2022 06:04:15 -0700 (PDT) Received: from [10.225.1.43] (unknown [10.225.1.43]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MTZ5m4MZWz1RvLy; Fri, 16 Sep 2022 06:04:12 -0700 (PDT) Message-ID: <601f0825-0569-3840-9fb0-b35a95b0a7e8@opensource.wdc.com> Date: Fri, 16 Sep 2022 14:04:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings Content-Language: en-US To: matoro Cc: Sreekanth Reddy , "Martin K. Petersen" , linux-scsi , Sathya Prakash , Suganath Prabu Subramani , PDL-MPT-FUSIONLINUX References: <20220307234854.148145-1-damien.lemoal@opensource.wdc.com> <13f2f53e87ff7b653c46c3da19ea8115@matoro.tk> <840410bd27c152079ea4cd483d58f416@matoro.tk> <6f7eb148-0506-a0de-3931-962b68d70fad@opensource.wdc.com> <03a8ae3e5179a817c551b80d3dfc41a3@matoro.tk> <7e26f8493fbd321e010930f2b636859c@matoro.tk> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <7e26f8493fbd321e010930f2b636859c@matoro.tk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2022/09/15 16:55, matoro wrote: > Hi Damien, apologies for continuing to bother. Did you get a chance to > put together a quick fix for this to test? I posted a revert for the 2 patches. I did try to fix this without reintroducing the sparse warnings, but I do not have any specification for the Broadcom HBA controller to know the exact endianness of the controller registers. So for now, instead of blindly trying fixing this, I reverted. > > -------- Original Message -------- > Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings > Date: 2022-08-22 13:53 > From: Damien Le Moal > To: matoro > > On 2022/08/22 10:51, matoro wrote: >> Hi Damien, were you able to put together a fix to test? We're up to >> 5.19.3 now and 5.18 was just marked EOL, so I want to make sure this >> doesn't drop off the radar. > > No, sorry, I have been busy as I am traveling. Flying back home this > week, so > likely will have more time next week. > >> >> -------- Original Message -------- >> Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings >> Date: 2022-08-11 15:17 >> From: Damien Le Moal >> To: matoro >> >> On 2022/08/11 12:05, matoro wrote: >>> Just a small update, the module stuff turned out to be a separate, >>> unrelated regression. I bisected that one also (applying these >>> reverts >>> each time to allow me to boot) and reported it to Masahiro, who put in >>> a >>> fix for it here: >>> https://lore.kernel.org/all/20220809141117.641543-1-masahiroy@kernel.org/ >>> . So you can ignore that stuff. Are these two commits still planned >>> to >>> be reverted? >> >> Revert should be a last resort (I really want to get rid of all these >> sparse >> warnings !). Let me first try to generate a fix for you to test. >> >>> >>> -------- Original Message -------- >>> Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings >>> Date: 2022-08-02 19:36 >>> From: Damien Le Moal >>> To: matoro , Sreekanth Reddy >>> >>> >>> On 8/3/22 05:27, matoro wrote: >>>> Hi folks, sorry for the lateness, unfortunately this is in fact >>>> broken >>>> on BE. I use mpt3sas on sparc and my drives fail to come up on 5.19, >>>> bisected to this patchset. Reverting both of the endian-related >>>> commits, b4efbec4c2a75b619fae4e8768be379e88c78687 and >>>> 7ab4d2441b952977556672c2fe3f4c2a698cbb37, allows it to boot. >>>> However, >>>> after booting, I can't load any modules - everything errors with >>>> "disagrees about version of symbol module_layout". I have completely >>>> wiped out kernel sources, the module tree, and the kernel image, >>>> rebuilding both from scratch with ONLY the revert patch applied, but >>>> I >>>> still can't load any modules. Presumably it would work with >>>> CONFIG_MODVERSIONS=n, but these CRC checks are there for a reason and >>>> I >>>> can't tell if it has something to do with the revert or not. >>> >>> For b4efbec4c2a75b619fae4e8768be379e88c78687, removing the >>> cpu_to_le32() >>> call results in the bytes actually being reversed by writel()/readl() >>> for >>> your BE machine. So it looks like the values that need to be written >>> to >>> the HBA have to be in CPU endian, not le32. Should be easy to fix. >>> And for 7ab4d2441b952977556672c2fe3f4c2a698cbb37, this looks like the >>> same >>> problem. >>> >>> I will be traveling and busy this week, but I can have a look at a fix >>> next Monday. If the Broadcom folks can send a fix faster than that, >>> that >>> is of course welcome :) >>> >>>> >>>> $ modprobe --dump-modversions >>>> /lib/modules/5.19.0-gentoo-sparc64/kernel/fs/openpromfs/openpromfs.ko >>>> | >>>> grep "module_layout" >>>> 0xa6c23707 module_layout >>>> $ grep "module_layout" /usr/src/linux/Module.symvers >>>> 0xa6c23707 module_layout vmlinux EXPORT_SYMBOL >>>> >>>> If you need real hardware access and do not have any on hand, please >>>> reach out and I can provide temporary access! >>>> >>>> Here is the full error on vanilla 5.19: >>>> >>>> mpt3sas version 42.100.00.00 loaded >>>> mpt2sas_cm0: 64 BIT PCI BUS DMA ADDRESSING SUPPORTED, total mem >>>> (32650280 kB) >>>> mpt2sas_cm0: _base_wait_for_doorbell_not_used: failed due to timeout >>>> count(5000), doorbell_reg(18000000)! >>>> mpt2sas_cm0: CurrentHostPageSize is 0: Setting default host page size >>>> to >>>> 4k >>>> mpt2sas_cm0: MSI-X vectors supported: 1 >>>> no of cores: 64, max_msix_vectors: -1 >>>> mpt2sas_cm0: 0 1 1 >>>> mpt2sas_cm0: pci_alloc_irq_vectors failed (r=-22) !!! >>>> mpt2sas_cm0: High IOPs queues : disabled >>>> mpt2sas0: IO-APIC enabled: IRQ 4 >>>> mpt2sas_cm0: iomem(0x0000084100000000), mapped(0x(____ptrval____)), >>>> size(16384) >>>> mpt2sas_cm0: ioport(0x0000085100000000), size(256) >>>> mpt2sas_cm0: doorbell is in use (line=6869) >>>> mpt2sas_cm0: _base_get_ioc_facts: handshake failed (r=-14) >>>> mpt2sas_cm0: failure at >>>> drivers/scsi/mpt3sas/mpt3sas_scsih.c:12336/_scsih_probe()! >>>> mpt2sas_cm1: 64 BIT PCI BUS DMA ADDRESSING SUPPORTED, total mem >>>> (32650280 kB) >>>> mpt2sas_cm1: _base_wait_for_doorbell_not_used: failed due to timeout >>>> count(5000), doorbell_reg(18000000)! >>>> mpt2sas_cm1: CurrentHostPageSize is 0: Setting default host page size >>>> to >>>> 4k >>>> mpt2sas_cm1: MSI-X vectors supported: 1 >>>> no of cores: 64, max_msix_vectors: -1 >>>> mpt2sas_cm1: 0 1 1 >>>> mpt2sas_cm1: pci_alloc_irq_vectors failed (r=-22) !!! >>>> mpt2sas_cm1: High IOPs queues : disabled >>>> mpt2sas1: IO-APIC enabled: IRQ 5 >>>> mpt2sas_cm1: iomem(0x0000084120000000), mapped(0x(____ptrval____)), >>>> size(16384) >>>> mpt2sas_cm1: ioport(0x0000085100002000), size(256) >>>> mpt2sas_cm1: doorbell is in use (line=6869) >>>> mpt2sas_cm1: _base_get_ioc_facts: handshake failed (r=-14) >>>> mpt2sas_cm1: failure at >>>> drivers/scsi/mpt3sas/mpt3sas_scsih.c:12336/_scsih_probe()! >>>> >>>> -------- Original Message -------- >>>> Subject: Re: [PATCH v3 0/5] Fix mpt3sas driver sparse warnings >>>> Date: 2022-03-09 01:35 >>>> From: Sreekanth Reddy >>>> To: "Martin K. Petersen" >>>> >>>> On Wed, Mar 9, 2022 at 9:26 AM Martin K. Petersen >>>> wrote: >>>>> >>>>> >>>>> Sreekanth, >>>>> >>>>>> This series fix (remove) all sparse warnings generated when >>>>>> compiling >>>>>> the mpt3sas driver. All warnings are related to __iomem access and >>>>>> endianness. >>>>> >>>>> Please review this series and validate the patch 5 modification. >>>> >>>> Martin, >>>> This patch set looks good, but before acknowledging this patch set I >>>> just wanted to do some basic testing on a big endian machine. >>>> Currently I don't have a big endian machine, internally I am checking >>>> to get access to big endian machines. Meanwhile if anyone does a >>>> basic >>>> testing on any big endian machine then please let me know. I will add >>>> the acknowledgement signature. >>>> >>>> Thanks, >>>> Sreekanth >>>> >>>>> >>>>> Thanks! >>>>> >>>>> -- >>>>> Martin K. Petersen Oracle Linux Engineering >>> >> > -- Damien Le Moal Western Digital Research