From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DA9C1F3D56; Tue, 7 Jan 2025 18:00:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736272815; cv=none; b=O45KYHxhh4YznM3yd5uFpGo92NyX1BeHjjNMm+Dn1c3/y4KHm4BJ2GmItvEkJXy0Duo9MzHbNdzxGEKtE4HkLrmL1srppKDm8AkO5LEK7Ok9DyaXKyp/HucIsX9ZkSpcFMnXES+UvgupFUjsyyuc88KGKVU+vosPLmrXz+dgewc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736272815; c=relaxed/simple; bh=WV+TLZuDtrq0vN0L2SGNhb5nPcib4hM5tam8yfuu2ms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B3Ygp7DS0acazva8hoJJOk1CMutKf8qEqjpZO8ToG1V7DW4hHWBiLcy5ORJsC6oKSb5bO7ejvlH11K70pYGZ6q3X06il124j8T+mCouItIVPzWcmvvFmIj4kBKpISUxtbnpd1npQnBblqQ7oOlzeBi07cee4jQP9/edj1HOgE+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=fCAySHRa; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="fCAySHRa" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 507HHR9v017910; Tue, 7 Jan 2025 18:00:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=WV+TLZ uDtrq0vN0L2SGNhb5nPcib4hM5tam8yfuu2ms=; b=fCAySHRaqtq5fm5STvmk9q Lhs0czlU8stIqTWMs5CAVNZP6fwD1RMzrw/gpEC58ljZLGBvWSVqFumg7nBbYCOk MzLu4BwhrJm2KJgdANu2Xqg4s8Nb1FEJQ+mLJiP1TIwQXqSh4B5mZo5n4rfG+4GG o9gieyscm5rwgG+O9oBSUPiks2rsOACizCiqUYpzGG+pDvhKSORIKZ+J4WNZJQgJ E9SZsuEs0omj0ehqcNt1Bs15NLPt/gwc0keiNvDSFks5evXkws51oLgnHvmlxy6D MfwFs5ZrRfwxw7s9ntQJ/A0s3CZkZx+L2rYTjt+P+Udc8mX07+2FlsidHtroGjBA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4410f3ap5q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 17:59:59 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 507GdP97013645; Tue, 7 Jan 2025 17:59:59 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43yganuqj5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 17:59:59 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 507HxwOh38470348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2025 17:59:58 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9591E58056; Tue, 7 Jan 2025 17:59:58 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB04C58052; Tue, 7 Jan 2025 17:59:52 +0000 (GMT) Received: from [9.171.94.59] (unknown [9.171.94.59]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Jan 2025 17:59:51 +0000 (GMT) Message-ID: <60ac457f-d762-414b-9b3a-b85a2181c2ce@linux.ibm.com> Date: Tue, 7 Jan 2025 23:29:47 +0530 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] block: fix queue freeze vs limits lock order in sysfs store methods To: Christoph Hellwig , Jens Axboe Cc: Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20250107063120.1011593-1-hch@lst.de> <20250107063120.1011593-6-hch@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20250107063120.1011593-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SAmk3EbAribcnbNq4fhQEPQvwJ5g5bbV X-Proofpoint-ORIG-GUID: SAmk3EbAribcnbNq4fhQEPQvwJ5g5bbV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=531 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501070149 Looks good to me. Reviewed-by: Nilay Shroff