From: Johannes Thumshirn <jth@kernel.org>
To: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Doug Gilberg <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCHv2 4/6] sg: check for valid direction before starting the request
Date: Fri, 3 Feb 2017 13:36:42 +0100 [thread overview]
Message-ID: <61297b1c-aa07-4203-d45a-3ad58ca6f495@kernel.org> (raw)
In-Reply-To: <1486124305-104141-5-git-send-email-hare@suse.de>
On 02/03/2017 01:18 PM, Hannes Reinecke wrote:
> From: Johannes Thumshirn <jthumshirn@suse.de>
>
> Check for a valid direction before starting the request, otherwise we risk
> running into an assertion in the scsi midlayer checking for vaild requests.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Link: http://www.spinics.net/lists/linux-scsi/msg104400.html
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
[...]
>
> +static bool sg_is_valid_dxfer(sg_io_hdr_t *hp)
> +{
> + switch (dxfer_direction) {
This wont build now... needs a +hp
next prev parent reply other threads:[~2017-02-03 12:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 12:18 [PATCHv2 0/6] sanitize sg Hannes Reinecke
2017-02-03 12:18 ` [PATCHv2 1/6] sg: disable SET_FORCE_LOW_DMA Hannes Reinecke
2017-02-03 12:20 ` Johannes Thumshirn
2017-02-03 12:18 ` [PATCHv2 2/6] sg: remove 'save_scat_len' Hannes Reinecke
2017-02-03 12:21 ` Johannes Thumshirn
2017-02-03 12:18 ` [PATCHv2 3/6] sg: protect accesses to 'reserved' page array Hannes Reinecke
2017-02-03 12:23 ` Johannes Thumshirn
2017-02-03 12:18 ` [PATCHv2 4/6] sg: check for valid direction before starting the request Hannes Reinecke
2017-02-03 12:36 ` Johannes Thumshirn [this message]
2017-02-03 13:59 ` kbuild test robot
2017-02-03 12:18 ` [PATCHv2 5/6] sg: use standard lists for sg_requests Hannes Reinecke
2017-02-03 12:40 ` Johannes Thumshirn
2017-02-03 12:18 ` [PATCHv2 6/6] sg: close race condition in sg_remove_sfp_usercontext() Hannes Reinecke
2017-02-03 12:52 ` [PATCHv2 0/6] sanitize sg Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61297b1c-aa07-4203-d45a-3ad58ca6f495@kernel.org \
--to=jth@kernel.org \
--cc=dgilbert@interlog.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).