Re: [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools

Arnd Bergmann
2015-10-12T15:15:28Z

On Monday 12 October 2015 23:20:17 John Garry wrote:
> + interrupt_count = of_property_count_u32_elems(np, "interrupts");
> + if (interrupt_count < 0)
> + goto err_out;
> +
> + if (of_property_read_u32(np, "#interrupt-cells", &interrupt_cells))
> + goto err_out;
> +
> + hisi_hba->int_names = devm_kcalloc(&pdev->dev,
> + interrupt_count / interrupt_cells,
> + HISI_SAS_NAME_LEN,
> + GFP_KERNEL);
>

This computation looks wrong: the "interrupts" property refers to interrupts
that are referenced by this node and provided by an interrupt-controller,
while the "#interrupt-cells" property refers to interrupts provided by
this node. They don't need to have any relation.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html