Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code

Arnd Bergmann
2015-10-13T12:47:19Z

On Tuesday 13 October 2015 13:44:26 John Garry wrote:
> Hello,
>
> Just to be clear, are you saying that you would prefer hisi_sas_probe()
> and struct hisi_sas_driver to be relocated to hisi_sas_v1_hw.c?

Correct.

> I wanted to keep hisi_sas_v1_hw.c containing only code which accesses HW.
>
> I could consoldate the calls of hw_init_v1_hw(), interrupt_init_v1_hw(),
> interrupt_openall_v1_hw(), and phys_init_v1_hw() to a single function hw
> init function call. Then most of the code in the probe function will not
> be specific to v1.

This is more about correct layering of the code. Generally we want the
more specific modules on top to call into the more general code in
the bottom of the stack. Shared code should know as little as possible
about the specific implementations it is shared with.

Arnd