From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90210E95A8E for ; Mon, 9 Oct 2023 06:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345265AbjJIGlp (ORCPT ); Mon, 9 Oct 2023 02:41:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbjJIGln (ORCPT ); Mon, 9 Oct 2023 02:41:43 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBA3DA3; Sun, 8 Oct 2023 23:41:42 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7E6261F891; Mon, 9 Oct 2023 06:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696833701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n6ru4BeyFXFdIt7eil+7eK2LWQQrOHgO9/SgXh0HGFc=; b=pmaN8BgIPtZrrBGeuZG5pswC4yD2ai3zE1359VbUxtF4F4b89cFu1L90uU6zuYvaO/Cvx7 c8vtayGS/p009rMFdhQM6FCDq/qcuJGTMmTOY02EPj3MFvLNfBv4H/o2gBdBscO6+RWp1r kNRlrX11LwXzBNmpOvIodOSFF6una6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696833701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n6ru4BeyFXFdIt7eil+7eK2LWQQrOHgO9/SgXh0HGFc=; b=7owIMAyADACiStz5o/BUvG+Atv8ED2Tl9/DJ9lSW0bWeB0sxTj9P8eoryNAfggy4Ft7w5G 0d7D35iZ1lC+n9Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 06C7113586; Mon, 9 Oct 2023 06:41:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6Gc0OqSgI2UmCgAAMHmgww (envelope-from ); Mon, 09 Oct 2023 06:41:40 +0000 Message-ID: <61967481-4606-4375-9d21-25e314bbcdbe@suse.de> Date: Mon, 9 Oct 2023 08:41:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] scsi: libsas: Delete sas_ssp_task.retry_count Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, dlemoal@kernel.org References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-6-john.g.garry@oracle.com> From: Hannes Reinecke In-Reply-To: <20230814141022.36875-6-john.g.garry@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 8/14/23 16:10, John Garry wrote: > Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new > driver"), sas_ssp_task.retry_count is only ever set, so delete it. > > The aic94xx driver also had its own retry_count definition in struct scb > sub-structs, which may have caused a mix-up. > > Signed-off-by: John Garry > --- > drivers/scsi/libsas/sas_ata.c | 1 - > drivers/scsi/libsas/sas_scsi_host.c | 1 - > include/scsi/libsas.h | 2 -- > 3 files changed, 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman