From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <dlemoal@kernel.org>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH v3 1/5] scsi: libsas: Refactor dev_is_sata()
Date: Fri, 1 Aug 2025 08:32:05 +0200 [thread overview]
Message-ID: <61d0b771-e602-4a14-b429-7d38113a1f99@suse.de> (raw)
In-Reply-To: <20250724000235.143460-2-dlemoal@kernel.org>
On 7/24/25 02:02, Damien Le Moal wrote:
> Use a switch statement in dev_is_sata() to make the code more readable
> (and probably slightly better than a series of or conditions). Also have
> this inline function return a boolean instead of an integer.
>
> No functional changes.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> ---
> include/scsi/sas_ata.h | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-08-01 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 0:02 [PATCH v3 0/5] libsas cleanups Damien Le Moal
2025-07-24 0:02 ` [PATCH v3 1/5] scsi: libsas: Refactor dev_is_sata() Damien Le Moal
2025-08-01 6:32 ` Hannes Reinecke [this message]
2025-07-24 0:02 ` [PATCH v3 2/5] scsi: libsas: Simplify sas_ata_wait_eh() Damien Le Moal
2025-07-24 6:43 ` John Garry
2025-08-01 6:32 ` Hannes Reinecke
2025-07-24 0:02 ` [PATCH v3 3/5] scsi: libsas: Make sas_get_ata_info() static Damien Le Moal
2025-08-01 6:33 ` Hannes Reinecke
2025-07-24 0:02 ` [PATCH v3 4/5] scsi: libsas: Move declarations of internal functions to sas_internal.h Damien Le Moal
2025-08-01 6:33 ` Hannes Reinecke
2025-07-24 0:02 ` [PATCH v3 5/5] scsi: libsas: Use a bool for sas_deform_port() second argument Damien Le Moal
2025-08-01 6:34 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d0b771-e602-4a14-b429-7d38113a1f99@suse.de \
--to=hare@suse.de \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox