From mboxrd@z Thu Jan 1 00:00:00 1970 From: ygardi@codeaurora.org Subject: Re: [PATCH v2 0/8] Fix error message and present UFS variant Date: Tue, 20 Oct 2015 08:03:30 -0000 Message-ID: <62b728c92e9ce90805038945ff27b76e.squirrel@www.codeaurora.org> References: <1440335381-5122-1-git-send-email-ygardi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43904 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbbJTIDb (ORCPT ); Tue, 20 Oct 2015 04:03:31 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Akinobu Mita Cc: Yaniv Gardi , Rob Herring , Jej B , Paul Bolle , Christoph Hellwig , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv > Hi Yaniv, > > 2015-08-23 22:09 GMT+09:00 Yaniv Gardi : >> V3: fixes a few minor issues. >> >> V2: fixes a few issues of unnecessary EXPORT_SYMBOL, >> types of parameters in routine definition, >> build errors in case CONFIG_PM is not defined and some >> other minor fixes. > > I've checked outstanding issues I reported for v1 and v2 are fixed > in this version of series. So please feel free to add: > > Reviewed-by: Akinobu Mita > > I still think that we should introduce print_hex_dump_io() or > something simpler for dumping __iomem pointer instead of casting > 'void __force *'. But it is only used for debug dump function, so > I don't too much worry about it. > Thanks, Mita, as you say, since this is mainly for debug dump functions, so i agree that for now, we may keep it as is. Yaniv