From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "avri.altman@wdc.com" <avri.altman@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cw9316.lee@samsung.com" <cw9316.lee@samsung.com>,
"chenyuan0y@gmail.com" <chenyuan0y@gmail.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"ping.gao@samsung.com" <ping.gao@samsung.com>,
"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: ufs: mcq: delete ufshcd_release_scsi_cmd in ufshcd_mcq_abort
Date: Tue, 20 May 2025 02:40:55 +0000 [thread overview]
Message-ID: <63383483544a5f673f8b3fb7e47ea163f5d05541.camel@mediatek.com> (raw)
In-Reply-To: <20250519025559.1263821-1-ping.gao@samsung.com>
On Mon, 2025-05-19 at 10:55 +0800, ping.gao wrote:
> after ufs UFS_ABORT_TASK process successfully , host will generate
> mcq irq for abort tag with response OCS_ABORTED
> ufshcd_compl_one_cqe ->
> ufshcd_release_scsi_cmd
>
> But in ufshcd_mcq_abort already do ufshcd_release_scsi_cmd, this
> means
> __ufshcd_release will be done twice.
>
> This means hba->clk_gating.active_reqs also will be decrease twice,
> it
> will be negtive, so delete ufshcd_release_scsi_cmd in
> ufshcd_mcq_abort
> function.
>
> static void __ufshcd_release(struct ufs_hba *hba)
> {
> if (!ufshcd_is_clkgating_allowed(hba))
> return;
>
> hba->clk_gating.active_reqs--;
>
> if (hba->clk_gating.active_reqs < 0) {
> panic("ufs abnormal active_reqs!!!!!!");
> }
>
> ...
> }
>
> Fixes: f1304d442077 ("scsi: ufs: mcq: Added ufshcd_mcq_abort()")
> Signed-off-by: ping.gao <ping.gao@samsung.com>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2025-05-20 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250519025509epcas5p2bdc884392dafa224289b337c1232daf3@epcas5p2.samsung.com>
2025-05-19 2:55 ` [PATCH] scsi: ufs: mcq: delete ufshcd_release_scsi_cmd in ufshcd_mcq_abort ping.gao
2025-05-19 21:03 ` Bart Van Assche
2025-05-20 2:40 ` Peter Wang (王信友) [this message]
2025-05-21 1:39 ` Martin K. Petersen
[not found] <CGME20250516083723epcas5p216a21ffb81631d35f0a12f7a583ea248@epcas5p2.samsung.com>
2025-05-16 8:38 ` ping.gao
2025-05-16 9:36 ` Peter Wang (王信友)
2025-05-16 14:18 ` Bart Van Assche
2025-05-17 5:28 ` kernel test robot
2025-05-28 2:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63383483544a5f673f8b3fb7e47ea163f5d05541.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=chenyuan0y@gmail.com \
--cc=cw9316.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=minwoo.im@samsung.com \
--cc=ping.gao@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox