From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00359C433ED for ; Thu, 13 May 2021 01:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7EA461405 for ; Thu, 13 May 2021 01:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234256AbhEMBQ0 (ORCPT ); Wed, 12 May 2021 21:16:26 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:32363 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233250AbhEMBQ0 (ORCPT ); Wed, 12 May 2021 21:16:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1620868517; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=0HUdi3RVnrIz9MP5yZUO5pEKm9r054S5adp5gghHIuo=; b=KBmCIzAwDg9HglTybJF8/EEX1eblk1+gTaNJp3N+XvfHQbLN8xHY0cXKDkIcEuuG+8hNeJvy 85PXpjyH5ozY1FARUoQBdXTdQVRq2GOF/3GMl1LGCh6lg/EmG4EZaa0PLV+I3ify+3Qkt1kv cYJyp5g10l4CBhxxYVO4XTno4BU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJlNmU5NiIsICJsaW51eC1zY3NpQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 609c7da1938a1a6b8f70dd92 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 13 May 2021 01:15:13 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 24EDCC359F4; Thu, 13 May 2021 01:15:12 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0EE32C35960; Thu, 13 May 2021 01:15:09 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 13 May 2021 09:15:09 +0800 From: Can Guo To: Bean Huo Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Adrian Hunter , Jaegeuk Kim , Kiwoong Kim , Satya Tangirala , open list Subject: Re: [PATCH v5 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes In-Reply-To: References: <1619058521-35307-1-git-send-email-cang@codeaurora.org> <1619058521-35307-2-git-send-email-cang@codeaurora.org> Message-ID: <638d9eb678db15e95317c16f2313ea19@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2021-05-13 04:21, Bean Huo wrote: > On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote: >> + >> >> +static DEVICE_ATTR_RW(monitor_enable); >> >> +static DEVICE_ATTR_RW(monitor_chunk_size); >> >> +static DEVICE_ATTR_RO(read_total_sectors); >> >> +static DEVICE_ATTR_RO(read_total_busy); >> >> +static DEVICE_ATTR_RO(read_nr_requests); >> >> +static DEVICE_ATTR_RO(read_req_latency_avg); >> >> +static DEVICE_ATTR_RO(read_req_latency_max); >> >> +static DEVICE_ATTR_RO(read_req_latency_min); >> >> +static DEVICE_ATTR_RO(read_req_latency_sum); >> >> +static DEVICE_ATTR_RO(write_total_sectors); >> >> +static DEVICE_ATTR_RO(write_total_busy); >> >> +static DEVICE_ATTR_RO(write_nr_requests); >> >> +static DEVICE_ATTR_RO(write_req_latency_avg); >> >> +static DEVICE_ATTR_RO(write_req_latency_max); >> >> +static DEVICE_ATTR_RO(write_req_latency_min); >> >> +static DEVICE_ATTR_RO(write_req_latency_sum); > > Can, > > I like this series of patches, which can help me monitor UFS > performance online. I have a suggestion, how do you think that we add > this to ufs-debugfs. Then we don't need to poll each parameter one by > one, just one interface. > > Bean Hi Bean, Thanks for your suggestion, put it into debugfs is also an option. But on Android, debugfs is not mounted by default (the requirement from Google). So it is convenient to have it in sysfs, and one can use below cmd (as I listed in the cover letter) to poll all parameters at once : "grep ^ /dev/null *". Thanks, Can Guo.