From: Markus Elfring <Markus.Elfring@web.de>
To: Yongzhi Liu <hyperlyzcs@gmail.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Saurav Kashyap <skashyap@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
huntazhang@tencent.com, jitxie@tencent.com
Subject: Re: [PATCH V2] scsi: qla2xxx: Fix double free of fcport in error handling path
Date: Sun, 28 Apr 2024 14:52:50 +0200 [thread overview]
Message-ID: <63caf898-8072-48fe-ba7a-2e10e5b2d8ab@web.de> (raw)
In-Reply-To: <20240428113404.12522-1-hyperlyzcs@gmail.com>
…
> Fix this by cleaning up the redundant qla2x00_free_fcport() and
> replacing error handling with a goto chain.
…
Can the following wording approach be a bit nicer?
Thus clean duplicate qla2x00_free_fcport() calls up
and use more common error handling code instead.
> ---
> drivers/scsi/qla2xxx/qla_iocb.c | 13 +++++--------
…
Unfortunately, you overlooked to add a patch version description behind the marker line.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n713
…
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
…
> @@ -2787,6 +2783,7 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
>
> wait_for_completion(&elsio->u.els_logo.comp);
>
> +free_sp:
* I suggest to omit a blank line here.
* How do you think about to use the label “put_ref”?
> /* ref: INIT */
> kref_put(&sp->cmd_kref, qla2x00_sp_release);
> return rval;
Regards,
Markus
next prev parent reply other threads:[~2024-04-28 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:37 [PATCH] scsi: qla2xxx: Fix double free of fcport in error handling path Yongzhi Liu
2024-04-25 11:31 ` Markus Elfring
2024-04-28 11:34 ` [PATCH V2] " Yongzhi Liu
2024-04-28 12:52 ` Markus Elfring [this message]
2024-04-29 5:12 ` Markus Elfring
2024-04-30 9:11 ` [PATCH V3 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb Yongzhi Liu
2024-04-30 9:11 ` [PATCH V3 2/2] scsi: qla2xxx: Optimisation of exception handling " Yongzhi Liu
2024-04-30 11:21 ` Markus Elfring
2024-05-06 12:38 ` [PATCH V4 0/2] Bugfix and optimisation of exception handling Yongzhi Liu
2024-05-06 12:38 ` [PATCH V4 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb() Yongzhi Liu
2024-05-06 12:38 ` [PATCH V4 2/2] scsi: qla2xxx: Use common error handling code " Yongzhi Liu
2024-04-30 9:55 ` [PATCH V3 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63caf898-8072-48fe-ba7a-2e10e5b2d8ab@web.de \
--to=markus.elfring@web.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@oracle.com \
--cc=huntazhang@tencent.com \
--cc=hyperlyzcs@gmail.com \
--cc=jitxie@tencent.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox