From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63151C61DA4 for ; Thu, 2 Feb 2023 20:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232375AbjBBU2d (ORCPT ); Thu, 2 Feb 2023 15:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232159AbjBBU2b (ORCPT ); Thu, 2 Feb 2023 15:28:31 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2601039283 for ; Thu, 2 Feb 2023 12:28:30 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id v6-20020a17090ad58600b00229eec90a7fso6651032pju.0 for ; Thu, 02 Feb 2023 12:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kCeSKsaiEn0ZIK4bA5yE4w/pjc6DqI6l1J6JDIP3nQA=; b=fyLHSpVqKD2jEZCRFdH9Hm9DZGY4bwXlC1M1zi883+qOV+pc56CQalsX0kjMJc8MI+ XYAi1mUqqlyTJ7C/Qd3A+4Tt26YQPzCnDidTIjuQ55zm0q+okDtQ8esuws3SJHpmMxDv L8L2JLR26CAdCKs7V541FTwTpfsEYz2LHlPUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kCeSKsaiEn0ZIK4bA5yE4w/pjc6DqI6l1J6JDIP3nQA=; b=wLZjl8aeHa5lnBqNZnF1FV+UVWvcC4jk7xD3AcnXRmU+LtNM6eYcJSh2j6QfEFqUK1 unN5H89bdVX4IO4cyAbFhbucaI4Npt/As+YdPLVRDFzYG7f1iN5tpgpHKg4N4dexXVY+ VRwFTrMgy2GFuJfQ1kGJtuYH/QWULS1RG1Qfql5Sm6q90b067jg9kjo1F0TEhOxfz/RB MW8LRNyX76hz0iRwTrN54omF3LncPGwh6vOZLcfNlATCKiaXOvQqKgfa5yG1D5Az2F/I 8qizMO/68Gx4oFXRyyDxuLZVntQvk03vRR48bbCxqeqnwO1bkZKcQW3QbqeavN/z6QnZ 77QQ== X-Gm-Message-State: AO0yUKXhdSeCOl4n/UdsaT5YB1tokH3nv2eGe/t2gFXoWYAK1d9LIADk eYdI1M+E5YrxKckUCZvbEbgNJg== X-Google-Smtp-Source: AK7set8/0ss9qYyQiFWrVF9nmGsWNhlsjTyaztcZXm/XLquFezmkBOFFR1j2rtW4e/z2gad/W90XuQ== X-Received: by 2002:a17:903:230d:b0:196:4fe3:21b1 with SMTP id d13-20020a170903230d00b001964fe321b1mr8477930plh.27.1675369709462; Thu, 02 Feb 2023 12:28:29 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id p6-20020a170902780600b001929f0b4582sm63943pll.300.2023.02.02.12.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 12:28:29 -0800 (PST) Message-ID: <63dc1ced.170a0220.f43a2.02c5@mx.google.com> X-Google-Original-Message-ID: <202302022028.@keescook> Date: Thu, 2 Feb 2023 20:28:28 +0000 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Kevin Barnett , Don Brace , storagedev@microchip.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 2/3][next] scsi: smartpqi: Replace one-element arrays with flexible-array members References: <62bb7891b3a752e7302286030ba9fafe58dffb1e.1663816572.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62bb7891b3a752e7302286030ba9fafe58dffb1e.1663816572.git.gustavoars@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Sep 21, 2022 at 11:29:29PM -0500, Gustavo A. R. Silva wrote: > One-element arrays are deprecated, and we are replacing them with flexible > array members instead. So, replace one-element array with flexible-array > member in structures report_phys_lun_8byte_wwid_list and > report_phys_lun_16byte_wwid_list. > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines > on memcpy(). > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/KSPP/linux/issues/204 > Signed-off-by: Gustavo A. R. Silva Are there any binary differences after this patch? I assume not, so: Reviewed-by: Kees Cook > --- > drivers/scsi/smartpqi/smartpqi.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h > index d1756c9d1112..b31b42530674 100644 > --- a/drivers/scsi/smartpqi/smartpqi.h > +++ b/drivers/scsi/smartpqi/smartpqi.h > @@ -982,12 +982,12 @@ struct report_phys_lun_16byte_wwid { > > struct report_phys_lun_8byte_wwid_list { > struct report_lun_header header; > - struct report_phys_lun_8byte_wwid lun_entries[1]; > + struct report_phys_lun_8byte_wwid lun_entries[]; > }; > > struct report_phys_lun_16byte_wwid_list { > struct report_lun_header header; > - struct report_phys_lun_16byte_wwid lun_entries[1]; > + struct report_phys_lun_16byte_wwid lun_entries[]; > }; > > struct raid_map_disk_data { > -- > 2.34.1 > -- Kees Cook