RE: [PATCH V2 05/13] pm80xx : Support for char device.

Deepak.Ukey
2020-01-21T05:33:20Z

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Martin,

> Thanks for the commit message, looks much better. In the past, people
> are against IOCTL, suggesting netlink, have you considered that?

Not so keen on adding more ioctls. It's 2020 and all...

Given the nature of the exported information, what's wrong with putting it in sysfs?
-- We have some upcoming patches which uses this IOCTL interface and that cannot be supported through sysfs.
Below are the patches in this patchset which requires IOCTL interface.
0007-pm80xx-IOCTL-functionality-to-get-phy-status
0008-pm80xx-IOCTL-functionality-to-get-phy-error
0009-pm80xx-IOCTL-functionality-for-GPIO
0010-pm80xx-IOCTL-functionality-for-SGPIO
0013-pm80xx-IOCTL-functionality-for-TWI-device

Regards,
Deepak