public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Brian King <brking@linux.ibm.com>, martin.petersen@oracle.com
Cc: James.Bottomley@HansenPartnership.com,
	linux-scsi@vger.kernel.org, tyreld@linux.ibm.com,
	brking@pobox.com
Subject: Re: [PATCH] ibmvfc: Add max_sectors module parameter
Date: Tue, 10 Sep 2024 15:25:47 +0200	[thread overview]
Message-ID: <65366f3b-8f4d-49f0-9fdd-573f99d5b503@suse.de> (raw)
In-Reply-To: <20240730175118.27105-1-brking@linux.ibm.com>

On 7/30/24 19:51, Brian King wrote:
> There are some scenarios that can occur, such as performing an
> upgrade of the virtual I/O server, where the supported max transfer
> of the backing device for an ibmvfc HBA can change. If the max
> transfer of the backing device decreases, this can cause issues with
> previously discovered LUNs. This patch accomplishes two things.
> First, it changes the default ibmvfc max transfer value to 1MB.
> This is generally supported by all backing devices, which should
> mitigate this issue out of the box. Secondly, it adds a module
> parameter, enabling a user to increase the max transfer value to
> values that are larger than 1MB, as long as they have configured
> these larger values on the virtual I/O server as well.
> 
> Signed-off-by: Brian King <brking@linux.ibm.com>
> ---
>   drivers/scsi/ibmvscsi/ibmvfc.c | 10 +++++++---
>   drivers/scsi/ibmvscsi/ibmvfc.h |  2 +-
>   2 files changed, 8 insertions(+), 4 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich


      parent reply	other threads:[~2024-09-10 13:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 17:51 [PATCH] ibmvfc: Add max_sectors module parameter Brian King
2024-08-12 20:22 ` Martin Wilck
2024-08-12 21:45   ` Brian King
2024-08-30 20:42     ` [PATCH v2] " Brian King
2024-09-02  9:52       ` Martin Wilck
2024-09-03 13:47         ` [PATCH v3] " Brian King
2024-09-03 14:42           ` Martin Wilck
2024-09-09  9:07             ` Martin Wilck
2024-09-13  0:19           ` Martin K. Petersen
2024-09-19 15:52           ` Martin K. Petersen
2024-09-10 13:25 ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65366f3b-8f4d-49f0-9fdd-573f99d5b503@suse.de \
    --to=hare@suse.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=brking@linux.ibm.com \
    --cc=brking@pobox.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tyreld@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox