From: Bart Van Assche <bvanassche@acm.org>
To: David Jeffery <djeffery@redhat.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: core: run queues for all non-SDEV_DEL devices from scsi_run_host_queues
Date: Wed, 13 May 2026 14:58:12 -0700 [thread overview]
Message-ID: <65a4ac0a-ea6f-4a83-958c-169d4e2a62e8@acm.org> (raw)
In-Reply-To: <20260513173552.9222-1-djeffery@redhat.com>
On 5/13/26 10:35 AM, David Jeffery wrote:
> + if (sdev->sdev_state == SDEV_DEL ||
> + !get_device(&sdev->sdev_gendev))
> + continue;
A comment would be welcome above this statement that explains that
get_device() is called instead of scsi_device_get() because the latter
skips devices that are in the state SDEV_CANCEL state.
Thanks,
Bart.
prev parent reply other threads:[~2026-05-13 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 17:35 [PATCH] scsi: core: run queues for all non-SDEV_DEL devices from scsi_run_host_queues David Jeffery
2026-05-13 17:48 ` Bart Van Assche
2026-05-13 18:20 ` David Jeffery
2026-05-13 21:24 ` Bart Van Assche
2026-05-13 21:58 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a4ac0a-ea6f-4a83-958c-169d4e2a62e8@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=djeffery@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox