From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"colin.i.king@gmail.com" <colin.i.king@gmail.com>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] scsi: ufs: host: mediatek: make read-only array scale_us static const
Date: Mon, 22 Dec 2025 08:13:00 +0000 [thread overview]
Message-ID: <65daa0cefe5c09d138bdc545be23be9e58d7e762.camel@mediatek.com> (raw)
In-Reply-To: <20251219214428.492744-1-colin.i.king@gmail.com>
On Fri, 2025-12-19 at 21:44 +0000, Colin Ian King wrote:
> Don't populate the read-only array scale_us on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/ufs/host/ufs-mediatek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-
> mediatek.c
> index ecbbf52bf734..66b11cc0703b 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1112,7 +1112,7 @@ static void ufs_mtk_setup_clk_gating(struct
> ufs_hba *hba)
> unsigned long flags;
> u32 ah_ms = 10;
> u32 ah_scale, ah_timer;
> - u32 scale_us[] = {1, 10, 100, 1000, 10000, 100000};
> + static const u32 scale_us[] = {1, 10, 100, 1000, 10000,
> 100000};
>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2025-12-22 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 21:44 [PATCH][next] scsi: ufs: host: mediatek: make read-only array scale_us static const Colin Ian King
2025-12-22 8:13 ` Peter Wang (王信友) [this message]
2026-01-04 21:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65daa0cefe5c09d138bdc545be23be9e58d7e762.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=Chaotian.Jing@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chu.stanley@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox