From: Bart Van Assche <bvanassche@acm.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>,
manivannan.sadhasivam@linaro.org,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, andersson@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>,
Nitin Rawat <quic_nitirawa@quicinc.com>
Subject: Re: [PATCH V3] scsi: ufs: qcom: Enable UFS Shared ICE Feature
Date: Tue, 17 Dec 2024 07:46:15 -0800 [thread overview]
Message-ID: <65f95b01-8d2d-4e03-88a2-c501379f21ea@acm.org> (raw)
In-Reply-To: <20241217144059.30693-1-quic_rdwivedi@quicinc.com>
On 12/17/24 6:40 AM, Ram Kumar Dwivedi wrote:
> + unsigned int val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
> + unsigned int config;
> +
> + if (!is_ice_config_supported(host))
> + return;
> +
> + config = val[0] | (val[1] << 8) | (val[2] << 16) | (val[3] << 24);
Has it been considered to change the data type of val[] from unsigned
int into u8 or uint8_t? That would allow to use get_unaligned_le32()
instead of the above bit-shift expression. Additionally, why has
'config' been declared as 'int' instead of 'u32'?
Thanks,
Bart.
next prev parent reply other threads:[~2024-12-17 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 14:40 [PATCH V3] scsi: ufs: qcom: Enable UFS Shared ICE Feature Ram Kumar Dwivedi
2024-12-17 15:46 ` Bart Van Assche [this message]
2024-12-18 15:18 ` Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f95b01-8d2d-4e03-88a2-c501379f21ea@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rdwivedi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox