From: Markus Elfring <Markus.Elfring@web.de>
To: Jianhao Xu <jianhao.xu@seu.edu.cn>, Zilin Guan <zilin@seu.edu.cn>,
linux-scsi@vger.kernel.org, storagedev@microchip.com,
Don Brace <don.brace@microchip.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: hpsa: Fix memory leak in hpsa_undo_allocations_after_kdump_soft_reset()
Date: Tue, 30 Dec 2025 13:09:14 +0100 [thread overview]
Message-ID: <667efc45-7970-4064-8357-0c1d9acf3d66@web.de> (raw)
In-Reply-To: <20251229152938.481054-1-zilin@seu.edu.cn>
…
> +++ b/drivers/scsi/hpsa.c
> @@ -8212,6 +8212,8 @@ static void hpsa_undo_allocations_after_kdump_soft_reset(struct ctlr_info *h)
> h->monitor_ctlr_wq = NULL;
> }
>
> + kfree(h->reply_map); /* init_one 1 */
> + h->reply_map = NULL; /* init_one 1 */
I find this reset statement redundant here.
> kfree(h); /* init_one 1 */
> }
Regards,
Markus
next prev parent reply other threads:[~2025-12-30 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 15:29 [PATCH] scsi: hpsa: Fix memory leak in hpsa_undo_allocations_after_kdump_soft_reset() Zilin Guan
2025-12-30 12:09 ` Markus Elfring [this message]
2025-12-31 14:56 ` Zilin Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667efc45-7970-4064-8357-0c1d9acf3d66@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=don.brace@microchip.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=storagedev@microchip.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox