Re: [PATCH v2 11/13] scsi: fnic: Use fnic_lock to protect fnic structures in queuecommand

Hannes Reinecke
2023-11-02T08:02:12Z

On 10/27/23 20:03, Karan Tilak Kumar wrote:
> fnic does not use host_lock. fnic uses fnic_lock.
> Use fnic lock to protect fnic members in fnic_queuecommand.
> Add log messages in error cases.
>
> Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 28 +++++++++++++++++++++++++---
> 1 file changed, 25 insertions(+), 3 deletions(-)
>
Please merge this patch with the previous one which removes the use of
'host_lock', seeing that you need a lock after all.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman