From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>,
mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, agross@kernel.org,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/4] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller
Date: Mon, 11 Aug 2025 16:43:59 +0200 [thread overview]
Message-ID: <67aedb2a-3ccc-4440-b2ff-b3dbedf5e25c@kernel.org> (raw)
In-Reply-To: <20250811143139.16422-3-quic_rdwivedi@quicinc.com>
On 11/08/2025 16:31, Ram Kumar Dwivedi wrote:
> Enable Multi-Circular Queue (MCQ) support for the UFS host controller
> on the Qualcomm SM8650 platform by updating the device tree node. This
> includes adding new register region for MCQ and specifying the MSI parent
> required for MCQ operation.
>
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Way you organize your patchset is confusing. Why DTS is in the middle?
It suggests dependency and this would be strong objection from me.
Please read carefully writing bindings, submitting patches in DT and SoC
maintainer profile.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-11 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 14:31 [PATCH V2 0/4] Enable UFS MCQ support for SM8650 and SM8750 Ram Kumar Dwivedi
2025-08-11 14:31 ` [PATCH V2 1/4] dt-bindings: ufs: qcom: Document MCQ register space for UFS Ram Kumar Dwivedi
2025-08-11 14:42 ` Krzysztof Kozlowski
2025-08-11 16:12 ` Ram Kumar Dwivedi
2025-08-11 17:10 ` Krzysztof Kozlowski
2025-08-11 15:02 ` Bjorn Andersson
2025-08-11 16:52 ` Ram Kumar Dwivedi
2025-08-11 17:11 ` Krzysztof Kozlowski
2025-08-11 14:31 ` [PATCH V2 2/4] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller Ram Kumar Dwivedi
2025-08-11 14:43 ` Krzysztof Kozlowski [this message]
2025-08-11 16:54 ` Ram Kumar Dwivedi
2025-08-11 17:13 ` Krzysztof Kozlowski
2025-08-12 10:55 ` Dmitry Baryshkov
2025-08-12 15:23 ` Ram Kumar Dwivedi
2025-08-11 14:31 ` [PATCH V2 3/4] arm64: dts: qcom: sm8750: " Ram Kumar Dwivedi
2025-08-11 14:31 ` [PATCH V2 4/4] ufs: ufs-qcom: Streamline UFS MCQ resource mapping Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67aedb2a-3ccc-4440-b2ff-b3dbedf5e25c@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_rdwivedi@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox