From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>
Cc: jaegeuk@kernel.org, asutoshd@codeaurora.org,
nguyenb@codeaurora.org, hongwus@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] scsi: ufs: Fix a race condition btw task management request send and compl
Date: Sun, 31 Jan 2021 18:27:41 -0800 [thread overview]
Message-ID: <687cc78a-cb07-bd4f-e1c7-1ff0aeaef6b5@acm.org> (raw)
In-Reply-To: <56b26318de92eb88d663bbdc7096edcf@codeaurora.org>
On 1/28/21 10:29 PM, Can Guo wrote:
> On second thought, actually the 1st fix alone is enough to eliminate the
> race condition. Because blk_mq_tagset_busy_iter() only iterates over all
> requests which are not in IDLE state, if blk_mq_start_request() is called
> within the protection of host spin lock, ufshcd_compl_tm() shall not run
> into the scenario where req->end_io_data is set but
> REG_UTP_TASK_REQ_DOOR_BELL
> has not been set. What do you think?
That sounds reasonable to me.
Thanks,
Bart.
next prev parent reply other threads:[~2021-02-01 2:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 4:16 [PATCH v3 0/3] Three fixes for task management request implementation Can Guo
2021-01-28 4:16 ` [PATCH v3 1/3] scsi: ufs: Fix task management request completion timeout Can Guo
2021-01-29 3:22 ` Bart Van Assche
2021-01-29 5:46 ` Can Guo
2021-01-28 4:16 ` [PATCH v3 2/3] scsi: ufs: Fix a race condition btw task management request send and compl Can Guo
2021-01-29 3:20 ` Bart Van Assche
2021-01-29 6:06 ` Can Guo
2021-01-29 6:29 ` Can Guo
2021-02-01 2:27 ` Bart Van Assche [this message]
2021-01-28 4:16 ` [PATCH v3 3/3] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs Can Guo
2021-01-29 3:15 ` Bart Van Assche
2021-01-29 5:57 ` Can Guo
2021-02-01 2:39 ` Bart Van Assche
2021-02-05 6:09 ` Can Guo
2021-02-07 2:50 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687cc78a-cb07-bd4f-e1c7-1ff0aeaef6b5@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox