From: ygardi@codeaurora.org
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Yaniv Gardi <ygardi@codeaurora.org>,
"robherring2@gmail.com" <robherring2@gmail.com>,
"James.Bottomley@HansenPartnership.com"
<james.bottomley@hansenpartnership.com>,
"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
"hch@infradead.org" <hch@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"santoshsy@gmail.com" <santoshsy@gmail.com>,
"linux-scsi-owner@vger.kernel.org"
<linux-scsi-owner@vger.kernel.org>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"gbroner@codeaurora.org" <gbroner@codeaurora.org>,
"draviv@codeaurora.org" <draviv@codeaurora.org>,
Maya Erez <merez@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jbottomley@odin.com>
Subject: RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers
Date: Mon, 1 Feb 2016 10:40:25 -0000 [thread overview]
Message-ID: <6945e53b5c34415df0b60c7efb9f21aa.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B41E4C272@hasmsx108.ger.corp.intel.com>
>
>
>> + cdb_len = min_t(unsigned short, lrbp->cmd->cmd_len, MAX_CDB_SIZE);
>> + memcpy(ucd_req_ptr->sc.cdb, lrbp->cmd->cmnd, cdb_len);
>> + if (cdb_len < MAX_CDB_SIZE)
>> + memset(ucd_req_ptr->sc.cdb + cdb_len, 0,
>> + (MAX_CDB_SIZE - cdb_len));
> It's just 16 bytes, setting all to zero prior to copy will be as good as
> this if statement
> memset(ucd_req_ptr->sc.cdb, 0, MAX_CDB_SIZE);
>
i agree. will be modified in V7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-01 10:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 13:13 [PATCH v6 00/15] Big fixes, retries, handle a race condition Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers Yaniv Gardi
2015-11-02 19:33 ` Winkler, Tomas
2016-02-01 10:40 ` ygardi [this message]
2015-10-28 13:13 ` [PATCH v6 02/15] scsi: ufs: clear fields " Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 03/15] scsi: ufs: verify command tag validity Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 04/15] scsi: ufs: clear outstanding_request bit in case query timeout Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 05/15] scsi: ufs: increase fDeviceInit query response timeout Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 06/15] scsi: ufs: avoid exception event handler racing with PM callbacks Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes Yaniv Gardi
2015-10-30 12:16 ` Hannes Reinecke
2016-02-01 11:39 ` ygardi
2015-10-28 13:13 ` [PATCH v6 08/15] scsi: ufs: add retries to dme_peer get and set attribute Yaniv Gardi
2015-10-28 13:13 ` [PATCH v6 09/15] scsi: ufs: add retries for hibern8 enter Yaniv Gardi
2015-10-28 13:14 ` [PATCH v6 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure Yaniv Gardi
2015-10-28 13:14 ` [PATCH v6 11/15] scsi: ufs: retry failed query flag requests Yaniv Gardi
2015-10-28 13:14 ` [PATCH v6 12/15] scsi: ufs: reduce the interrupts for power mode change requests Yaniv Gardi
2015-10-28 13:14 ` [PATCH v6 13/15] scsi: ufs: add missing memory barriers Yaniv Gardi
2015-10-28 13:14 ` [PATCH v6 14/15] scsi: ufs: commit descriptors before setting the doorbell Yaniv Gardi
2015-10-28 13:14 ` [PATCH v6 15/15] scsi: ufs: add wrapper for retrying sending query attribute Yaniv Gardi
2015-10-30 12:20 ` [PATCH v6 00/15] Big fixes, retries, handle a race condition Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6945e53b5c34415df0b60c7efb9f21aa.squirrel@www.codeaurora.org \
--to=ygardi@codeaurora.org \
--cc=draviv@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jbottomley@odin.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=pebolle@tiscali.nl \
--cc=robherring2@gmail.com \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).