From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rolf Eike Beer" Subject: Re: [PATCH 07/18] qla2xxx: Fix to include FCE data as part of dump. Date: Wed, 14 Dec 2011 13:26:22 +0100 Message-ID: <69671e7c39ea17eb4be7123ab0d89fb9.squirrel@webmail.sf-mail.de> References: <1321635802-16491-1-git-send-email-chad.dupuis@qlogic.com> <1321635802-16491-8-git-send-email-chad.dupuis@qlogic.com> <1323864196.3063.55.camel@dabdike> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from mail.sf-mail.de ([62.27.20.61]:55911 "EHLO mail.sf-mail.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894Ab1LNM07 (ORCPT ); Wed, 14 Dec 2011 07:26:59 -0500 In-Reply-To: <1323864196.3063.55.camel@dabdike> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Chad Dupuis , giridhar.malavali@qlogic.com, andrew.vasquez@qlogic.com, linux-scsi@vger.kernel.org > On Fri, 2011-11-18 at 09:03 -0800, Chad Dupuis wrote: >> From: Giridhar Malavali >> >> Signed-off-by: Giridhar Malavali >> Signed-off-by: Chad Dupuis >> --- >> drivers/scsi/qla2xxx/qla_dbg.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/scsi/qla2xxx/qla_dbg.c >> b/drivers/scsi/qla2xxx/qla_dbg.c >> index 58e0bfb..8607ab7 100644 >> --- a/drivers/scsi/qla2xxx/qla_dbg.c >> +++ b/drivers/scsi/qla2xxx/qla_dbg.c >> @@ -369,7 +369,7 @@ qla25xx_copy_fce(struct qla_hw_data *ha, void *ptr, >> uint32_t **last_chain) >> >> memcpy(iter_reg, ha->fce, ntohl(fcec->size)); >> >> - return iter_reg; >> + return (void *)iter_reg + ntohl(fcec->size); > > That should be (char *). (void *) is a pointer to an incomplete type > and as such pointer arithmetic on it is technically illegal. gcc treats > it as char * for this purpose, so the expression works, but other > compilers (or some future version of gcc) might not be so lenient. Docbook/kernel-hacking.tmpl: GNU Extensions are explicitly allowed in the Linux kernel. ... -Arithmetic on void pointers Eike