From: Bean Huo <huobean@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: Stanley Chu <stanley.chu@mediatek.com>,
Can Guo <cang@codeaurora.org>, Bean Huo <beanhuo@micron.com>,
Asutosh Das <asutoshd@codeaurora.org>
Subject: Re: [PATCH] scsi: ufs: add missing host_lock in setup_xfer_req
Date: Tue, 13 Jul 2021 21:45:45 +0200 [thread overview]
Message-ID: <69b367bc44084f901d0d71fb8f9633ea7e5df36b.camel@gmail.com> (raw)
In-Reply-To: <38432018-e8bf-f9f3-00bf-cd4b81c95c88@acm.org>
On Tue, 2021-07-13 at 12:06 -0700, Bart Van Assche wrote:
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -1229,8 +1229,13 @@ static inline int
> > ufshcd_vops_pwr_change_notify(struct ufs_hba *hba,
> > static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba
> > *hba, int tag,
> > bool is_scsi_cmd)
> > {
> > - if (hba->vops && hba->vops->setup_xfer_req)
> > - return hba->vops->setup_xfer_req(hba, tag,
> > is_scsi_cmd);
> > + if (hba->vops && hba->vops->setup_xfer_req) {
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(hba->host->host_lock, flags);
> > + hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd);
> > + spin_unlock_irqrestore(hba->host->host_lock, flags);
> > + }
> > }
> >
> > static inline void ufshcd_vops_setup_task_mgmt(struct ufs_hba
> > *hba,
>
>
> Can anyone help with reviewing this patch?
>
>
>
> Thanks,
>
>
>
Hi Bart,
This change only impacts on the Samsung exynos platform. and Can's
optimization patch is to optimise the host_lock,, and removed
host_lock, now add back in this function makes sense to me.
but I am thinking how about hba->host_sem?
Bean
Bean
> Bart.
next prev parent reply other threads:[~2021-07-13 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 0:51 [PATCH] scsi: ufs: add missing host_lock in setup_xfer_req Jaegeuk Kim
2021-07-01 15:23 ` Bart Van Assche
2021-07-01 17:00 ` Bart Van Assche
2021-07-13 19:06 ` Bart Van Assche
2021-07-13 19:45 ` Bean Huo [this message]
2021-07-14 18:09 ` Bart Van Assche
2021-07-14 21:22 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b367bc44084f901d0d71fb8f9633ea7e5df36b.camel@gmail.com \
--to=huobean@gmail.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).