From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E293C4320A for ; Wed, 18 Aug 2021 11:29:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A3DA6109E for ; Wed, 18 Aug 2021 11:29:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235406AbhHRL3t (ORCPT ); Wed, 18 Aug 2021 07:29:49 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3659 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234913AbhHRL3t (ORCPT ); Wed, 18 Aug 2021 07:29:49 -0400 Received: from fraeml741-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GqQcz6wVqz6BHQS; Wed, 18 Aug 2021 19:28:19 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml741-chm.china.huawei.com (10.206.15.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 18 Aug 2021 13:29:12 +0200 Received: from [10.202.227.179] (10.202.227.179) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 18 Aug 2021 12:29:11 +0100 Subject: Re: [PATCH] scsi: ibmvfc: Stop using scsi_cmnd.tag To: "Martin K. Petersen" CC: , , , , , , , , , , , , References: <1629207817-211936-1-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <69c51e23-48b9-4672-e559-d2e257ade29f@huawei.com> Date: Wed, 18 Aug 2021 12:29:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.179] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Martin, > >> Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag. > > Applied to 5.15/scsi-staging and rebased for bisectability. > Thanks, and sorry for the hassle. But I would still like the maintainers to have a look, as I was curious about current usage of scsi_cmnd.tag in that driver. > Just to be picky it looks like there's another scsi_cmmd tag lurking in > qla1280.c but it's sitting behind an #ifdef DEBUG_QLA1280. > That driver does not even compile with DEBUG_QLA1280 set beforehand. I'll fix that up and send as separate patches in case you want to shuffle the tag patch in earlier, which is prob not worth the effort. I've done a good few more x86 randconfigs and tried to audit the code for more references, so hopefully that's the last. Thanks