From: Liang Haowen <nbg2974@gmail.com>
To: linux-leds@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Martin K . Petersen <mkp@kernel.org>,
linux-scsi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Denis Benato <denis.benato@linux.dev>,
Armin Wolf <W_Armin@gmx.de>, Hans de Goede <hansg@kernel.org>,
Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
Marco Scardovi <scardracs@disroot.org>
Subject: Re: [RFC v10 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures
Date: Thu, 15 Oct 2026 07:58:51 -0700 (PDT) [thread overview]
Message-ID: <6ad0ea2b.5be36480.2ae40.b460@mx.google.com> (raw)
In-Reply-To: <20261015140051.1159817-2-nbg2974@gmail.com>
The 0/1 cover letter for this series was blocked by my outgoing
mail provider and never reached the lists; resending its content
here.
v10, wiring the driver into the tree. A driver source file
without Kconfig and Makefile entries is dead code in the tree,
so this version adds them: LEDS_ASUS_AURA_SCSI sits inside the
LEDS_CLASS_MULTICOLOR block in drivers/leds/rgb/Kconfig with a
depends on SCSI, and the Makefile line beside the other rgb
drivers.
The only code change is strscpy() passing the buffer size
explicitly now. The two-argument form is supported by the
current string.h macros, but with the size written out the call
builds on any tree.
v10 was verified on hardware again after these changes: built
with clang against 7.2.4, the four LEDs set to independent
colours and confirmed by eye, 60 sequential and 100 concurrent
updates, the sdev deleted mid-write (zero splats, clean
detach), rmmod after detach, and a fresh attach through a host
scan.
The interface direction is unchanged from v9: the LED side will
move onto Marco's Dynamic Lighting class
(OpenGamingCollective/linux-unstable#17) once that settles.
prev parent reply other threads:[~2026-10-15 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261015140051.1159817-1-nbg2974@gmail.com>
2026-10-15 14:00 ` [RFC v10 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures Liang Haowen
2026-10-15 14:58 ` Liang Haowen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ad0ea2b.5be36480.2ae40.b460@mx.google.com \
--to=nbg2974@gmail.com \
--cc=W_Armin@gmx.de \
--cc=denis.benato@linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=pavel@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=scardracs@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox