From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chaitra Basappa Subject: RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization Date: Tue, 22 Mar 2016 15:35:54 +0530 Message-ID: <6b3eaa260503810f0a436dff32fc5a5a@mail.gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yw0-f175.google.com ([209.85.161.175]:35181 "EHLO mail-yw0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758368AbcCVKF6 (ORCPT ); Tue, 22 Mar 2016 06:05:58 -0400 Received: by mail-yw0-f175.google.com with SMTP id g127so247468352ywf.2 for ; Tue, 22 Mar 2016 03:05:57 -0700 (PDT) In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Martin K. Petersen" , Calvin Owens Cc: Sathya Prakash , Suganath Prabu Subramani , "James E.J. Bottomley" , PDL-MPT-FUSIONLINUX , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Sreekanth Reddy Martin, This patch is being reviewed , we shall get back with reviews by tomorrow. Thanks, Chaitra -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@oracle.com] Sent: Tuesday, March 22, 2016 6:00 AM To: Calvin Owens Cc: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J. Bottomley; Martin K. Petersen; MPT-FusionLinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-team@fb.com; Sreekanth Reddy Subject: Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization >>>>> "Calvin" == Calvin Owens writes: Calvin> In _base_make_ioc_operational(), we walk ioc->reply_queue_list Calvin> and pull a pointer out of successive elements of Calvin> ioc->reply_post[] for each entry in that list if RDPQ is Calvin> enabled. Calvin> Since the code pulls the pointer for the next iteration at the Calvin> bottom of the loop, it triggers the a KASAN dump on the final Calvin> iteration: Broadcom folks, please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering