From: Bart Van Assche <bvanassche@acm.org>
To: peter.wang@mediatek.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, avri.altman@wdc.com,
alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
cc.chou@mediatek.com, chaotian.jing@mediatek.com,
jiajie.hao@mediatek.com, powen.kao@mediatek.com,
qilin.tan@mediatek.com, lin.gui@mediatek.com,
tun-yu.yu@mediatek.com, eddie.huang@mediatek.com,
naomi.chu@mediatek.com, chu.stanley@gmail.com
Subject: Re: [PATCH v2 2/2] ufs: core: force reset after mcq abort all
Date: Tue, 27 Aug 2024 11:55:14 -0400 [thread overview]
Message-ID: <6bf76097-bcd7-4021-936f-9ea3d6e2f4b0@acm.org> (raw)
In-Reply-To: <20240826034509.17677-3-peter.wang@mediatek.com>
On 8/25/24 8:45 PM, peter.wang@mediatek.com wrote:
> From: Peter Wang <peter.wang@mediatek.com>
>
> In mcq mode gerneal case, cq (head/tail) pointer is same as
Please capitalize "MCQ" and please fix the spelling of "general".
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 4bcd4e5b62bd..d9ef8f0279da 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6519,6 +6519,8 @@ static bool ufshcd_abort_all(struct ufs_hba *hba)
> /* Complete the requests that are cleared by s/w */
> ufshcd_complete_requests(hba, false);
>
> + if (is_mcq_enabled(hba))
> + return true;
> return ret != 0;
> }
Please add a comment above the new if-test that explains why that code
is present otherwise it will be hard to understand why that statement
has been introduced.
Thanks,
Bart.
next prev parent reply other threads:[~2024-08-27 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 3:45 [PATCH v2 0/2] ufs: core: fix err handler mcq abort defect peter.wang
2024-08-26 3:45 ` [PATCH v2 1/2] ufs: core: complete scsi command after release peter.wang
2024-08-27 15:52 ` Bart Van Assche
2024-08-26 3:45 ` [PATCH v2 2/2] ufs: core: force reset after mcq abort all peter.wang
2024-08-27 15:55 ` Bart Van Assche [this message]
2024-08-28 13:44 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf76097-bcd7-4021-936f-9ea3d6e2f4b0@acm.org \
--to=bvanassche@acm.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chu.stanley@gmail.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox