public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>,
	Martin Petersen <martin.petersen@oracle.com>,
	target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, linux@yadro.com
Subject: Re: [PATCH] scsi: target: fix default complete_type
Date: Thu, 5 Mar 2026 10:53:34 -0600	[thread overview]
Message-ID: <6d2112e5-a075-4891-9f32-9036e9528bed@oracle.com> (raw)
In-Reply-To: <20260305094539.5721-1-d.bogdanov@yadro.com>

On 3/5/26 3:45 AM, Dmitry Bogdanov wrote:
> There is copy&paste error, fix it by setting the actual variable.
> 
> Fixes: 06933066d88a3 ("scsi: target: Add support for completing commands from backend context")
> Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
> ---
>  drivers/target/target_core_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index fbc8ab65372e..9db2201aa553 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -813,7 +813,7 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
>  				DA_UNMAP_ZEROES_DATA_DEFAULT;
>  	dev->dev_attrib.max_write_same_len = DA_MAX_WRITE_SAME_LEN;
>  	dev->dev_attrib.submit_type = TARGET_FABRIC_DEFAULT_SUBMIT;
> -	dev->dev_attrib.submit_type = TARGET_FABRIC_DEFAULT_COMPL;
> +	dev->dev_attrib.complete_type = TARGET_FABRIC_DEFAULT_COMPL;
>  
>  	/* Skip allocating lun_stats since we can't export them. */
>  	xcopy_lun = &dev->xcopy_lun;

Thanks. There's another similar case. Let me ping Martin to see if he
wants me to resend the patchset or a patch on top of staging.

      reply	other threads:[~2026-03-05 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  9:45 [PATCH] scsi: target: fix default complete_type Dmitry Bogdanov
2026-03-05 16:53 ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d2112e5-a075-4891-9f32-9036e9528bed@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=d.bogdanov@yadro.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@yadro.com \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox